-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala 2.13.0-M4 support #225
Comments
prepare Scala 2.13.0-M4 #224 |
scalac-scoverage-plugin depends on scala-logging (only test) lightbend-labs/scala-logging#127 |
scala-logging 3.9.0 has now been published for M4 |
There is a problem with this version. Guys, I need you help. Here are the branches: Please, publish the plugin locally and try to build any project with
|
looks like you're doing XML stuff but don't have scala-xml on the classpath. as of 2.13.0-M4, scala-compiler no longer depends on scala-xml, that seems like a likely root cause idk, but perhaps this line of code needs updating? |
I have For me it looks like something has changed with plugin's classloader/classpath. |
I don't know of any Scala change that might cause that, other than the one I mentioned. Perhaps there is an implicit assumption in your code that loading the scala-compiler classes also causes the scala-xml classes to be loaded in the same classloader. |
I found it, Project's dependency on |
Tests in the 2.13.0-M4 tree seem to work fine, except for the yielder. Adding some embarrassing printf-debugging code, I was able to obtain a direct comparison. You can see that the new collections API eliminates two calls to |
(maybe not so hard — I'm not sure how widely known it is that you can have |
Now pull-request #228 tests fine in Travis. Splitting the test-base as suggested by @SethTisue would be an alternative, but perhaps it is a bit much for a problem validly solvable with a simple weakening of a single |
@JanBessai's changes are merged to master. Now we come to the point I've described above How to solve it? Scoverage needs |
Not sure, if the license allows for it, but could you perhaps use sbt-assembly and bundle scala-xml with the plugin jar? |
I don't want to do it. Actually I have experimental version of scoverage with plain text format of internal files. I've prepared it to compare performance with and without xml, but maybe now it's time to use it. |
If changing the file format is an option, you might also look at Jsoniter, which can generate runtime-dependency free json (un)parsers. |
Version |
please 😺
ref typelevel/cats#2267
The text was updated successfully, but these errors were encountered: