-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade#4 #1394
Merged
Merged
Upgrade#4 #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1394 +/- ##
===========================================
- Coverage 53.27% 52.63% -0.65%
===========================================
Files 155 156 +1
Lines 11774 12426 +652
===========================================
+ Hits 6273 6540 +267
- Misses 5006 5325 +319
- Partials 495 561 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com> Co-authored-by: Mengran Lan <mengran@scroll.io> Co-authored-by: amoylan2 <amoylan2@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io> Co-authored-by: Mengran Lan <lanmengran@qq.com> Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
colinlyguo
reviewed
Jul 8, 2024
Co-authored-by: georgehao <haohongfan@gmail.com>
…anges of BatchProvingTask & BundleProvingTask (#1434)
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
…#1461) Co-authored-by: georgehao <haohongfan@gmail.com>
amoylan2
reviewed
Jul 30, 2024
amoylan2
reviewed
Jul 30, 2024
amoylan2
reviewed
Jul 30, 2024
amoylan2
reviewed
Jul 30, 2024
colinlyguo
reviewed
Jul 30, 2024
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
colinlyguo
reviewed
Jul 30, 2024
colinlyguo
reviewed
Jul 30, 2024
colinlyguo
reviewed
Jul 30, 2024
amoylan2
previously approved these changes
Jul 31, 2024
colinlyguo
previously approved these changes
Jul 31, 2024
github-actions
bot
dismissed stale reviews from colinlyguo and amoylan2
via
July 31, 2024 09:19
4f098b4
colinlyguo
approved these changes
Jul 31, 2024
amoylan2
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Upgrade#4 develop branch, contains:
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?