Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade#4 #1394

Merged
merged 44 commits into from
Jul 31, 2024
Merged

Upgrade#4 #1394

merged 44 commits into from
Jul 31, 2024

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Jun 24, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Upgrade#4 develop branch, contains:

  1. rollup_relayer
  2. coordinator
  3. prover

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 42.96799% with 588 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (dd6206f) to head (0108046).

Files Patch % Lines
coordinator/internal/orm/bundle.go 0.00% 143 Missing ⚠️
rollup/internal/controller/relayer/l2_relayer.go 39.81% 98 Missing and 29 partials ⚠️
rollup/internal/utils/utils.go 0.00% 75 Missing ⚠️
rollup/internal/orm/bundle.go 63.42% 44 Missing and 20 partials ⚠️
coordinator/internal/orm/batch.go 0.00% 39 Missing ⚠️
...lup/internal/controller/watcher/bundle_proposer.go 68.64% 27 Missing and 10 partials ⚠️
rollup/internal/orm/batch.go 58.90% 23 Missing and 7 partials ⚠️
coordinator/internal/types/auth.go 50.00% 14 Missing and 7 partials ⚠️
coordinator/internal/types/prover.go 0.00% 16 Missing ⚠️
coordinator/internal/orm/l2_block.go 0.00% 10 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1394      +/-   ##
===========================================
- Coverage    53.27%   52.63%   -0.65%     
===========================================
  Files          155      156       +1     
  Lines        11774    12426     +652     
===========================================
+ Hits          6273     6540     +267     
- Misses        5006     5325     +319     
- Partials       495      561      +66     
Flag Coverage Δ
bridge-history-api 71.16% <ø> (ø)
common 47.35% <0.00%> (-2.32%) ⬇️
coordinator 17.68% <24.00%> (-2.26%) ⬇️
database 42.85% <ø> (ø)
rollup 57.17% <52.29%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

colinlyguo and others added 12 commits June 25, 2024 10:13
Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
Co-authored-by: Mengran Lan <mengran@scroll.io>
Co-authored-by: amoylan2 <amoylan2@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Co-authored-by: Mengran Lan <lanmengran@qq.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
prover/Cargo.toml Outdated Show resolved Hide resolved
@georgehao georgehao changed the title (WIP) Upgrade#4 Upgrade#4 Jul 9, 2024
georgehao and others added 3 commits July 30, 2024 14:53
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
amoylan2
amoylan2 previously approved these changes Jul 31, 2024
colinlyguo
colinlyguo previously approved these changes Jul 31, 2024
@georgehao georgehao added the bump-version Bump the version tag for deployment label Jul 31, 2024
@github-actions github-actions bot dismissed stale reviews from colinlyguo and amoylan2 via 4f098b4 July 31, 2024 09:19
@georgehao georgehao merged commit 04215f3 into develop Jul 31, 2024
@georgehao georgehao deleted the feat/upgrade4 branch July 31, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants