chore: Update go version in go.mod

[jmeridth]

This will match go 1.19.x that is used in the Dockerfile already

Notes:

• Why are there two require sections now?
  • Because in Go 1.17 the module graph has been changed to enable pruning and lazy loading. The second require block contains indirect dependencies
• CI
  • Lowest chamber builds for is 1.15 here

[jmeridth]

@alecjacobs5401 are you a good person to take a look at this one or is someone else better? Thank you for any insight. Cheers.

[alecjacobs5401]

Hey @jmeridth - sorry for the late response! We've been discussing this internally for a little and are thinking through potential consequences of this change immediately.

On one hand, this is a good change and we'd like to enforce a newer go version. On the other, we are investigating the potential downstream impact to implementing libraries that might pull in chamber packages (i.e. not just using chamber as a CLI, using its internals in other go packages)

We did some looking around and it looks like mostly forks of chamber exist, but there is at least one Repository where chamber is pulled in as a package.

By changing the go version in go.mod, we do cause some potential for breaking behavior by now requiring any implementing packages to adhere to a new minimum go version.

I'm going to rope in @knksmith57 to handoff to since he is our current on-call engineer and we'll work out next steps.

[jmeridth]

@alecjacobs5401 That makes sense. anytime we upgrade to a minor (especially major) version, those are the things you have to triple check. Thank you for the response. Looking forward to seeing how this pans out. Cheers.

[jmeridth]

@alecjacobs5401 @knksmith57 would you prefer I closed this PR and let y'all converse and we can either reopen or create another one if decision is made to move forward? Don't want this hanging open if the timeline is a bit out. wdyt?

[knksmith57]

Hey @jmeridth I synced with the team today and I think this warrants more internal discussion based on potential blast radius.

I'm going to sync with one of our Principal's tomorrow about next steps. For now, agreed, let's close this one so it isn't floating around.

Thank you, again, for bringing this to our attention and for the PR 🙏

[jmeridth]

@knksmith57 any chance of progress on this idea internally? Thank you in advance for any updates. Cheers.

[jmeridth]

Nm. Looks like you all upgraded to 1.19 here. Nice.

[jmeridth]

Solved by #383