What If... our Go dependencies were current? #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings with it a LOT of dependency upgrades, which is probably a good thing overall. Whether or not it breaks tests is a different question. Note that this also includes a change to the declared package path for analytics-go from "gopkg.in/segmentio/analytics-go.v3" to "github.com/segmentio/analytics-go/v3".
analytics-go has changed their import path from "gopkg.in/segmentio/analytics-go.v3" to "github.com/segmentio/analytics-go/v3", so we must update accordingly.
nitrocode
previously approved these changes
May 4, 2023
mckern
changed the title
alecjacobs5401
previously approved these changes
May 9, 2023
This was referenced May 10, 2023
alecjacobs5401
approved these changes
May 10, 2023
|
@alecjacobs5401 when can we see a new release? Thank you so much for getting this change over the finish line. Cheers. |
|
@alecjacobs5401 @jmeridth I need to write release notes and update the README. That's the blocker right now. |
|
@mckern saw the release happened last week. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ground work for some other maintenance PRs that are coming over the wire soon. All existing tests are passing for this, but test coverage is still kind-of low so take this with a grain of salt.
closes #381