-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What If... our Go dependencies were current? #383
Conversation
This brings with it a LOT of dependency upgrades, which is probably a good thing overall. Whether or not it breaks tests is a different question. Note that this also includes a change to the declared package path for analytics-go from "gopkg.in/segmentio/analytics-go.v3" to "github.com/segmentio/analytics-go/v3".
analytics-go has changed their import path from "gopkg.in/segmentio/analytics-go.v3" to "github.com/segmentio/analytics-go/v3", so we must update accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments that I don't think are necessarily blockers for this PR specifically.
Thanks for doing this Ryan!
@alecjacobs5401 when can we see a new release? Thank you so much for getting this change over the finish line. Cheers. |
@alecjacobs5401 @jmeridth I need to write release notes and update the README. That's the blocker right now. |
@mckern saw the release happened last week. Thank you. |
This is ground work for some other maintenance PRs that are coming over the wire soon. All existing tests are passing for this, but test coverage is still kind-of low so take this with a grain of salt.
closes #381