-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize top-level config keys #170
Milestone
Comments
Closed
Sereja313
added a commit
that referenced
this issue
Sep 27, 2022
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
12 tasks
Sereja313
added a commit
that referenced
this issue
Sep 27, 2022
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
12 tasks
Sereja313
added a commit
that referenced
this issue
Sep 28, 2022
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
Sereja313
added a commit
that referenced
this issue
Sep 28, 2022
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
Sereja313
added a commit
that referenced
this issue
Oct 5, 2022
Sereja313
added a commit
that referenced
this issue
Oct 25, 2022
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clarification and motivation
At the moment, the config yaml is organized in 3 top-level keys:
traversal
,verification
andscanners
.xrefcheck/src/Xrefcheck/Config/Default.hs
Lines 17 to 70 in 31777f7
However, as was discussed in this thread, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern.
A better way of organizing these options would be:
exclusions
:ignored
,notScanned
, ...networking
:externalRefCheckTimeout
,ignoreAuthFailures
,defaultRetryAfter
, ...scanners
Acceptance criteria
The yaml config options are organized under
exclusions
,networking
andscanners
.The text was updated successfully, but these errors were encountered: