[#170] [#119] Reorganize top-level config keys #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sereja313
force-pushed
the
Sereja313/#170-reorganize-config-keys
branch
from
5faded0 to
6e4891e
Compare
Sereja313
force-pushed
the
Sereja313/#156-trim-redundant-config-fields
branch
from
24ea5a9 to
8b8d8ee
Compare
Sereja313
force-pushed
the
Sereja313/#170-reorganize-config-keys
branch
2 times, most recently
from
a5fae5b to
108f9d3
Compare
Sorokin-Anton
approved these changes
Sep 28, 2022
Sereja313
force-pushed
the
Sereja313/#156-trim-redundant-config-fields
branch
from
8b8d8ee to
2bcbfa1
Compare
Base automatically changed from
Sereja313/#156-trim-redundant-config-fields
to
master
October 4, 2022 12:52
dcastro
approved these changes
Oct 4, 2022
dcastro
reviewed
Oct 4, 2022
Closed
dcastro
changed the title
|
This can now be rebased & merged |
Problem: At the moment, the config yaml is organized in 3 top-level keys: `traversal`, `verification` and `scanners`. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern. Solution: Reorganize yaml config options under `exclusions`, `networking` and `scanners`.
Sereja313
force-pushed
the
Sereja313/#170-reorganize-config-keys
branch
from
cb4e935 to
013457a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: At the moment, the config yaml is organized in 3 top-level keys:
traversal,verificationandscanners. However, the distinction between the "traversal" and the "verification" stages is not relevant to the user. This is entirely an internal concern.Solution: Reorganize yaml config options under
exclusions,networkingandscanners.Related issue(s)
Fixes #170
Fixes #119
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml.under the "Unreleased" section to a new section for this release version.
vX.Y.Z.xrefcheck-action.