-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metal documentation #5549
base: master
Are you sure you want to change the base?
Metal documentation #5549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of 09-targets.md is to provide an overview of what each target platform expects, and less about what Slang will do on that platform.
We will use separate chapters for each platform to list all the details about how Slang translate different things to that platform.
We need a document that is similar to https://github.com/shader-slang/slang/blob/master/docs/user-guide/a2-01-spirv-target-specific.md for Metal.
In which we talk about every detail about the platform, including how types and specific intrinsics (atomics, texture fetching etc.) are translated.
541de8f
to
1e4101f
Compare
Can you please create a file that is under docs/user-guide/a2-02-metal-target-specific.md and move all the details there? Then we can deep link into this doc from shader-slang.com/docs |
1e4101f
to
e9ea5a7
Compare
I've added that file populated with the functionality from the metal legalization source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
e9ea5a7
to
315bd3a
Compare
Thanks for the feedback, addressed. |
[[mesh]] | ||
void meshMain( | ||
uint tid [[thread_position_in_grid]], | ||
metal::mesh<VertexType, PrimitiveType, NumVertices, NumPrimitives, Topology> mesh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we support mesh shaders written in pure HLSL syntax without using metal specific types. Do we even have metal::mesh
? This should be updated to reflect what is in tests\metal\simple-mesh.slang
.
Closes #4262