Disable extension update messages #641

Stanzilla · 2018-09-13T16:04:01Z

🐛 Describe the bug
Even though quiet sync is enabled, it still pops up a browser window with the changelog after every option

🌴 Visual Studio Code Version: [ 1.27.1 ]
🌴 Code Settings Sync Version: [ 3.1.2 ]
🌴 Operating System : [ Windows 10 1803 ]
🌴 Occurs On: [ Updating the extension ]
🌴 Proxy Enabled: [ No ]
🌴 Gist Id: [ ID_HERE ]

📰 To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

💪 Expected behavior
A clear and concise description of what you expected to happen.

📺 Console Error Log
If applicable, add screenshots or paste the console log from developer console of VSCode.

📺 Additional context
Add any other context about the problem here.

shanalikhan · 2018-09-13T16:12:18Z

Oh.
It's just a one window that appears on every update.
U want "settings sync" completely quiet 😞 ?

Stanzilla · 2018-09-13T16:58:44Z

@shanalikhan pretty much, yeah. But you could put the release notes link into the notification that pops up, otherwise this just super disrupts my workflow with auto updates enabled, you are coding on something and suddenly your browser steals focus with a pop up :)

@sync

* chore(package): update tslint-plugin-prettier to version 2.0.0 * Updated: German translation * #641 * Add support for VSCodium * Corrected the message to be displayed * Add Japanese translation file * be able to upload additional file * be able to download additional files * create new advanced setting to add Customized Sync file * fix typo eslint => eslintrc * Add Import Custom File to workspace option * unify display message: Custom Sync File * Test Directory * =Adding HostName property. Get hostname using 'os.hostname()' * =Need definition for supported OS's. Using strict match regex to get @sync pragmas. Should it support multiple spaces? Replacing settings.json content before writing file. Should be better removing lines instead of add comments? Replacing settings.json before upload to remove @sync ignore pragms. * Added English message for OSNotSupported message while processing uploading content * mocha and chai packages added as dev dependencies. Test script not working while compiling. * Moving pragma functions to a separated file * Added Pragma util static class. Support for host, env and os values in every orther. Remove whitespaces before upload. Alert user if OS value is not a valid OS. * Added hostName property to CustomSettings * Tests files added. Estructure test per feature. * Added some documentation. hostName property on custom config. * uncomment lines function. Uncomment all @sync settings before upload. Only insert comments if it doesn't match with matchine os or host or env. Uncomment line before write if it matched. * Do replace ments one time per setting pragma. Test uncoment function. More redeable settings json for testing. * Add SUPPORTED_OS and osTypeFromString to environmentPath.ts as requested. Get OS from OsType enum. Remove os.hostName() * Check valid JSON before writting file. All the comments and trilling commas are removed. Must check this. If not valid OS is detected inform user. Added function to remove comments from text. * Chatch exception during upload. Should it abort upload? * Adding VS Code tests in typescript. Run test changing launch mode to "Launch Test". Remove javascript files. * Environment - treat non-OSS instalations on Linux as XDG * Improvements #628 , #629 * minor grammatical fixes * add fileService.test.ts * Version Change * #331 * #513 * Add webpack bundling (#676) * Update issue templates * add webpack bundling for faster startup * no conflicts * Revert "Add webpack bundling (#676)" (#679) This reverts commit e68a243. * Gist Object changed * Update package.json * v3.2 change log

nfour · 2018-11-02T05:28:08Z

This is maddening @shanalikhan, makes me want to disable it when it pops a browser window up every 30mins 😄

Stanzilla · 2018-11-02T10:37:22Z

Yeah same, also I seem to get the browser window open when OTHER extensions update sometimes, super weird.

nfour · 2018-11-06T00:30:09Z

Yeah same, also I seem to get the browser window open when OTHER extensions update sometimes, super weird.

That could be why it's so annoying - must be hooking into a generic event.

shanalikhan · 2018-11-08T10:45:18Z

@nfour

makes me want to disable it when it pops a browser window up every 30mins smile

Every 30 minutes, can you share the screen shot which extension is showing dialog in every 30mins?

nfour · 2018-11-09T03:45:20Z

It's not necessarily every 30 minutes but it does pop up multiple times per day. Not sure how I'd diagnose which extension is proccing it.

shanalikhan · 2018-11-09T09:35:48Z

Okay, when you get dialog, post the screen shot here so i will see.

shanalikhan · 2018-11-26T08:56:00Z

Not sure how I'd diagnose which extension is proccing it.

My bad, may be Settings Sync is throwing it.
Post the screen shot when you get any.

nfour · 2018-11-27T03:15:25Z

@shanalikhan

It pops that up when I open a new editor, sometimes. Then it opens the browser window.

I've looked at that file, write permissions are fine.

shanalikhan · 2018-11-27T08:27:42Z

The message and the image you have posted and different to what original issue is.
in latest version. I will ask you to reset the settings to make it valid JSON.

Can you post the file content when you get this message.

nfour · 2018-11-28T00:11:33Z

{
    "ignoreUploadFiles": [
        "projects.json",
        "projects_cache_git.json"
    ],
    "ignoreUploadFolders": [
        "workspaceStorage"
    ],
    "ignoreExtensions": [],
    "replaceCodeSettings": {},
    "gistDescription": "Visual Studio Code Settings Sync Gist",
    "version": 322,
    "token": "<snip>",
    "downloadPublicGist": false,
    "supportedFileExtensions": [
        "json",
        "code-snippets"
    ],
    "openTokenLink": true,
    "disableUpdateMessage": false,
    "lastUpload": "2018-11-28T00:09:16.218Z",
    "lastDownload": "2018-11-27T06:57:23.209Z",
    "githubEnterpriseUrl": null,
    "askGistName": false,
    "customFiles": {},
    "hostName": null,
    "useCliBaseInstallation": true
}

nfour · 2018-11-28T00:18:31Z

Haha when I restart vscode it opens a browser with for every single editor I have open with that same tab. This is ridiculous man XD. It doesn't show that syncSettings .json error popup though, it seems intermittent.

shanalikhan · 2018-11-28T08:34:11Z

There is similar issue opened, #706 , and users have auto upload or download on ? If you have either on them enabled - Turn them off and restart code and let me know if it helps.

Stanzilla · 2018-12-03T00:44:39Z

I have auto upload and download enabled, yea

PierreMarchand20 · 2019-02-04T12:42:16Z

I think that it would be more supportable if instead of opening a page in the browser, it would just open a page in vscode. Most extensions do that for news/updates information.

For example: https://github.com/alefragnani/vscode-project-manager

cr3ative · 2019-03-08T10:04:30Z

It looks like the original feature intent was added with disableUpdateMessage? Might be good to add this flag to the documentation.

shanalikhan · 2019-03-24T18:45:27Z

I think that it would be more supportable if instead of opening a page in the browser, it would just open a page in vscode. Most extensions do that for news/updates information.

Yes, i will setup a page in the future updates.

shanalikhan · 2019-04-04T20:02:13Z

disableUpdateMessage is added already.
Will add on documentation

shanalikhan changed the title ~~Silent option not working~~ Disable extension update messages Sep 16, 2018

shanalikhan added this to the v3.2 milestone Sep 16, 2018

shanalikhan added the improvement ✨ label Sep 16, 2018

shanalikhan added a commit that referenced this issue Sep 18, 2018

#641

1a21f37

shanalikhan added the fixed label Sep 18, 2018

shanalikhan added a commit that referenced this issue Sep 18, 2018

#641

54752d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable extension update messages #641

Disable extension update messages #641

Stanzilla commented Sep 13, 2018

shanalikhan commented Sep 13, 2018

Stanzilla commented Sep 13, 2018 •

edited

Loading

nfour commented Nov 2, 2018

Stanzilla commented Nov 2, 2018

nfour commented Nov 6, 2018

shanalikhan commented Nov 8, 2018

nfour commented Nov 9, 2018

shanalikhan commented Nov 9, 2018

shanalikhan commented Nov 26, 2018

nfour commented Nov 27, 2018 •

edited

Loading

shanalikhan commented Nov 27, 2018

nfour commented Nov 28, 2018 •

edited

Loading

nfour commented Nov 28, 2018 •

edited

Loading

shanalikhan commented Nov 28, 2018

Stanzilla commented Dec 3, 2018

PierreMarchand20 commented Feb 4, 2019 •

edited

Loading

cr3ative commented Mar 8, 2019

shanalikhan commented Mar 24, 2019

shanalikhan commented Apr 4, 2019

Disable extension update messages #641

Disable extension update messages #641

Comments

Stanzilla commented Sep 13, 2018

shanalikhan commented Sep 13, 2018

Stanzilla commented Sep 13, 2018 • edited Loading

nfour commented Nov 2, 2018

Stanzilla commented Nov 2, 2018

nfour commented Nov 6, 2018

shanalikhan commented Nov 8, 2018

nfour commented Nov 9, 2018

shanalikhan commented Nov 9, 2018

shanalikhan commented Nov 26, 2018

nfour commented Nov 27, 2018 • edited Loading

shanalikhan commented Nov 27, 2018

nfour commented Nov 28, 2018 • edited Loading

nfour commented Nov 28, 2018 • edited Loading

shanalikhan commented Nov 28, 2018

Stanzilla commented Dec 3, 2018

PierreMarchand20 commented Feb 4, 2019 • edited Loading

cr3ative commented Mar 8, 2019

shanalikhan commented Mar 24, 2019

shanalikhan commented Apr 4, 2019

Stanzilla commented Sep 13, 2018 •

edited

Loading

nfour commented Nov 27, 2018 •

edited

Loading

nfour commented Nov 28, 2018 •

edited

Loading

nfour commented Nov 28, 2018 •

edited

Loading

PierreMarchand20 commented Feb 4, 2019 •

edited

Loading