V3.2 #648
Merged
V3.2 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rking while compiling.
…n every orther. Remove whitespaces before upload. Alert user if OS value is not a valid OS.
… Only insert comments if it doesn't match with matchine os or host or env. Uncomment line before write if it matched.
… More redeable settings json for testing.
…ted. Get OS from OsType enum. Remove os.hostName()
…commas are removed. Must check this. If not valid OS is detected inform user. Added function to remove comments from text.
…"Launch Test". Remove javascript files.
…ettier-2.0.0 Update tslint-plugin-prettier to the latest version 🚀
fbehrens
reviewed
Oct 13, 2018
src/environmentPath.ts
Outdated
| this.OsType = OsType.Linux; | ||
| } else { | ||
| this.PATH = process.env.VSCODE_PORTABLE; | ||
| this.OsType = OsType.Linux; |
There was a problem hiding this comment.
should this be OsType.Windows ? (Just browsing the code)
There was a problem hiding this comment.
Very nice, Yes!
I will fix it.
Feel free to correct / improve where required.
As this update is huge and although i have tested well - i still expect issues 😄
* Update issue templates * add webpack bundling for faster startup * no conflicts
Gist Object changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.