-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webpack bundling #676
Add webpack bundling #676
Conversation
package.json
Outdated
"temp": "^0.8.3", | ||
"ts-loader": "^5.2.1", | ||
"webpack": "^4.20.2", | ||
"webpack-cli": "^3.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts-loader
, webpack
and webpack-cli
should be moved to devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always forget that :(
Can you resolve the conflicts. |
Can you just cherry-pick my commits |
Thanks! |
Following is my output for creating package in
|
This reverts commit e68a243.
Can you fix it.
Sync localization doesnt work. |
I have reverted this PR. |
* chore(package): update tslint-plugin-prettier to version 2.0.0 * Updated: German translation * #641 * Add support for VSCodium * Corrected the message to be displayed * Add Japanese translation file * be able to upload additional file * be able to download additional files * create new advanced setting to add Customized Sync file * fix typo eslint => eslintrc * Add Import Custom File to workspace option * unify display message: Custom Sync File * Test Directory * =Adding HostName property. Get hostname using 'os.hostname()' * =Need definition for supported OS's. Using strict match regex to get @sync pragmas. Should it support multiple spaces? Replacing settings.json content before writing file. Should be better removing lines instead of add comments? Replacing settings.json before upload to remove @sync ignore pragms. * Added English message for OSNotSupported message while processing uploading content * mocha and chai packages added as dev dependencies. Test script not working while compiling. * Moving pragma functions to a separated file * Added Pragma util static class. Support for host, env and os values in every orther. Remove whitespaces before upload. Alert user if OS value is not a valid OS. * Added hostName property to CustomSettings * Tests files added. Estructure test per feature. * Added some documentation. hostName property on custom config. * uncomment lines function. Uncomment all @sync settings before upload. Only insert comments if it doesn't match with matchine os or host or env. Uncomment line before write if it matched. * Do replace ments one time per setting pragma. Test uncoment function. More redeable settings json for testing. * Add SUPPORTED_OS and osTypeFromString to environmentPath.ts as requested. Get OS from OsType enum. Remove os.hostName() * Check valid JSON before writting file. All the comments and trilling commas are removed. Must check this. If not valid OS is detected inform user. Added function to remove comments from text. * Chatch exception during upload. Should it abort upload? * Adding VS Code tests in typescript. Run test changing launch mode to "Launch Test". Remove javascript files. * Environment - treat non-OSS instalations on Linux as XDG * Improvements #628 , #629 * minor grammatical fixes * add fileService.test.ts * Version Change * #331 * #513 * Add webpack bundling (#676) * Update issue templates * add webpack bundling for faster startup * no conflicts * Revert "Add webpack bundling (#676)" (#679) This reverts commit e68a243. * Gist Object changed * Update package.json * v3.2 change log
@shanalikhan this is for faster startups.
influenced by @fabiospampinato
refs #656 and #673