Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack bundling #676

Merged
merged 4 commits into from
Oct 15, 2018
Merged

Add webpack bundling #676

merged 4 commits into from
Oct 15, 2018

Conversation

NavyAdmiral
Copy link

@NavyAdmiral NavyAdmiral commented Oct 13, 2018

@shanalikhan this is for faster startups.
influenced by @fabiospampinato

refs #656 and #673

package.json Outdated
"temp": "^0.8.3",
"ts-loader": "^5.2.1",
"webpack": "^4.20.2",
"webpack-cli": "^3.1.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-loader, webpack and webpack-cli should be moved to devDependencies

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget that :(

@shanalikhan shanalikhan changed the base branch from master to v3.2 October 14, 2018 17:13
@shanalikhan
Copy link
Owner

Can you resolve the conflicts.

@shanalikhan shanalikhan added this to the v3.2 milestone Oct 14, 2018
@NavyAdmiral
Copy link
Author

Can you resolve the conflicts.

Can you just cherry-pick my commits

@shanalikhan shanalikhan merged commit e68a243 into shanalikhan:v3.2 Oct 15, 2018
@shanalikhan
Copy link
Owner

Thanks!

@shanalikhan
Copy link
Owner

Following is my output for creating package in vsce package

shan@shan-HP-ZBook-15:~/Documents/code-settings-sync$ vsce package
Executing prepublish script 'npm run vscode:prepublish'...

> code-settings-sync@3.2.0 vscode:prepublish /home/shan/Documents/code-settings-sync
> npm run tslint-check && npm run compile


> code-settings-sync@3.2.0 tslint-check /home/shan/Documents/code-settings-sync
> tslint -c ./tslint.json ./src/**/*.ts ./src/*.ts


> code-settings-sync@3.2.0 compile /home/shan/Documents/code-settings-sync
> webpack --mode production

Hash: 5d2d274795858771c4db
Version: webpack 4.20.2
Time: 6172ms
Built at: 10/15/2018 2:12:32 PM
           Asset     Size  Chunks             Chunk Names
    extension.js  591 KiB       0  [emitted]  main
extension.js.map    2 MiB       0  [emitted]  main
Entrypoint main = extension.js extension.js.map
  [0] external "path" 42 bytes {0} [built]
 [24] external "vscode" 42 bytes {0} [built]
 [46] ./src/localize.ts 4.13 KiB {0} [built]
 [59] ./src/environmentPath.ts 6.29 KiB {0} [built]
 [84] ./src/enums.ts 702 bytes {0} [built]
[119] ./src sync 160 bytes {0} [built]
[161] ./src/lockfile.ts 586 bytes {0} [built]
[171] ./src/service/fileService.ts 7.8 KiB {0} [built]
[172] ./src/setting.ts 2.1 KiB {0} [built]
[214] ./src/extension.ts 1.58 KiB {0} [built]
[236] ./src/sync.ts 45 KiB {0} [built]
[237] ./src/commons.ts 25.9 KiB {0} [built]
[387] ./src/service/githubService.ts 5.2 KiB {0} [built]
[542] ./src/service/pluginService.ts 17.2 KiB {0} [built]
[543] ./src/pragmaUtil.ts 8.21 KiB {0} [built]
    + 529 hidden modules

WARNING in ./src/localize.ts 89:40-89
Critical dependency: the request of a dependency is an expression
 @ ./src/extension.ts

WARNING in ./src/localize.ts 94:18-43
Critical dependency: the request of a dependency is an expression
 @ ./src/extension.ts

WARNING in ./node_modules/node-fetch/lib/index.mjs
Module not found: Error: Can't resolve 'encoding' in '/home/shan/Documents/code-settings-sync/node_modules/node-fetch/lib'
 @ ./node_modules/node-fetch/lib/index.mjs
 @ ./node_modules/@octokit/rest/lib/request/request.js
 @ ./node_modules/@octokit/rest/lib/request/index.js
 @ ./node_modules/@octokit/rest/index.js
 @ ./src/service/githubService.ts
 @ ./src/sync.ts
 @ ./src/extension.ts

WARNING in ./node_modules/adm-zip/util/fileSystem.js
Module not found: Error: Can't resolve 'original-fs' in '/home/shan/Documents/code-settings-sync/node_modules/adm-zip/util'
 @ ./node_modules/adm-zip/util/fileSystem.js
 @ ./node_modules/adm-zip/util/index.js
 @ ./node_modules/adm-zip/adm-zip.js
 @ ./src/util.ts
 @ ./src/commons.ts
 @ ./src/sync.ts
 @ ./src/extension.ts
Created: /home/shan/Documents/code-settings-sync/code-settings-sync-3.2.0.vsix (2092 files, 2.28MB)

shanalikhan added a commit that referenced this pull request Oct 15, 2018
@shanalikhan
Copy link
Owner

shanalikhan commented Oct 15, 2018

Can you fix it.
Try running the commands

vsce package
code --install-extension code-settings-sync-3.2.0.vsix

Sync localization doesnt work.
You can send new Pull Request to fix it.

@shanalikhan shanalikhan removed this from the v3.2 milestone Oct 16, 2018
@shanalikhan
Copy link
Owner

I have reverted this PR.
Feel free to send new one after testing.

shanalikhan added a commit that referenced this pull request Oct 16, 2018
shanalikhan added a commit that referenced this pull request Oct 17, 2018
* chore(package): update tslint-plugin-prettier to version 2.0.0

* Updated: German translation

* #641

* Add support for VSCodium

* Corrected the message to be displayed

* Add Japanese translation file

* be able to upload additional file

* be able to download additional files

* create new advanced setting to add Customized Sync file

* fix typo eslint => eslintrc

* Add Import Custom File to workspace option

* unify display message: Custom Sync File

* Test Directory

* =Adding HostName property. Get hostname using 'os.hostname()'

* =Need definition for supported OS's. Using strict match regex to get @sync pragmas. Should it support multiple spaces? Replacing settings.json content before writing file. Should be better removing lines instead of add comments? Replacing settings.json before upload to remove @sync ignore pragms.

* Added English message for OSNotSupported message while processing uploading content

* mocha and chai packages added as dev dependencies. Test script not working while compiling.

* Moving pragma functions to a separated file

* Added Pragma util static class. Support for host, env and os values in every orther. Remove whitespaces before upload. Alert user if OS value is not a valid OS.

* Added hostName property to CustomSettings

* Tests files added. Estructure test per feature.

* Added some documentation. hostName property on custom config.

* uncomment lines function. Uncomment all @sync settings before upload. Only insert comments if it doesn't match with matchine os or host or env. Uncomment line before write if it matched.

* Do replace ments one time per setting pragma. Test uncoment function. More redeable settings json for testing.

* Add SUPPORTED_OS and osTypeFromString to environmentPath.ts as requested. Get OS from OsType enum. Remove os.hostName()

* Check valid JSON before writting file. All the comments and trilling commas are removed. Must check this. If not valid OS is detected inform user. Added function to remove comments from text.

* Chatch exception during upload. Should it abort upload?

* Adding VS Code tests in typescript. Run test changing launch mode to "Launch Test". Remove javascript files.

* Environment - treat non-OSS instalations on Linux as XDG

* Improvements
#628 , #629

* minor grammatical fixes

* add fileService.test.ts

* Version Change

* #331

* #513

* Add webpack bundling (#676)

* Update issue templates

* add webpack bundling for faster startup

* no conflicts

* Revert "Add webpack bundling (#676)" (#679)

This reverts commit e68a243.

* Gist Object changed

* Update package.json

* v3.2 change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants