Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing print Github token. #974

Closed
ccinelli opened this issue Jul 19, 2019 · 4 comments
Closed

Syncing print Github token. #974

ccinelli opened this issue Jul 19, 2019 · 4 comments
Labels
fixed improvement ✨
Milestone
v3.4.2

Comments

@ccinelli
Copy link

ccinelli commented Jul 19, 2019 •
edited
Loading

The Github token should not be displayed in console.

CODE SETTINGS SYNC UPLOAD SUMMARY
Version: 3.4.0
--------------------
GitHub Token: [!!!!!!!]
GitHub Gist: 1234567890
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------

...

Consider encrypting the token in setting too.
@shanalikhan
Copy link
Owner

Since now Settings Sync automatically retrieves token from Github Application. I think its safe to remove from the summary.

@elfakyn
Copy link

elfakyn commented Jul 31, 2019

Came here to add a vote for this -- even on a non-autoretrieved token maybe truncate it to the first 4 characters if you need it to display at all? A readwrite gist token is pretty powerful.

@shanalikhan shanalikhan added this to the v3.4.2 milestone Jul 31, 2019
@shanalikhan
Copy link
Owner

maybe truncate it to the first 4 characters

Nice idea, will be fixed in upcoming version.

shanalikhan added a commit that referenced this issue Aug 19, 2019
@shanalikhan
#974
4cc9f17
@shanalikhan
Copy link
Owner

fixed,released

shanalikhan added a commit that referenced this issue Aug 22, 2019
@shanalikhan
V3.4.2 (#1008)
7c15602 
* Fix korean

* Fix: Ambiguous Expression and Korean naturally

* Missing keys

* Change `Sync :` to `Sync:`

* dev.to post updated

* #989

* Update package.nls.ko.json

fixing some wrong translate.

* Update ko-lang

Although translated, it some case may not be accurate.

* Fix GitHub spelling

* chore(package): update @types/chai to version 4.2.0

* Update french translation file

* Correcting the german translation

Checking the translation based on the package.nls.json file
Correcting the grammar for the german translation

* Correcting typos

Correcting spelling mistakes and typos

* Correcting spelling mistakes

Correcting more spelling mistakes

* #974

* #977
#989

* #1003 (#1012)

Also fix errors with settings containing backslashes.

* #983

* #1008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed improvement ✨
Projects
None yet
Milestone
v3.4.2
Development

No branches or pull requests
3 participants
@elfakyn @shanalikhan @ccinelli