Fix #1003 #1012
Merged
Fix #1003 #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanalikhan
added a commit
that referenced
this pull request
Aug 22, 2019
* Fix korean * Fix: Ambiguous Expression and Korean naturally * Missing keys * Change `Sync :` to `Sync:` * dev.to post updated * #989 * Update package.nls.ko.json fixing some wrong translate. * Update ko-lang Although translated, it some case may not be accurate. * Fix GitHub spelling * chore(package): update @types/chai to version 4.2.0 * Update french translation file * Correcting the german translation Checking the translation based on the package.nls.json file Correcting the grammar for the german translation * Correcting typos Correcting spelling mistakes and typos * Correcting spelling mistakes Correcting more spelling mistakes * #974 * #977 #989 * #1003 (#1012) Also fix errors with settings containing backslashes. * #983 * #1008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Also fixes errors with setting containing backslashes.
The regex expressions have been changed to not match brackets inside quote marks.
The logic now allows the user to have multi-line and nested settings. (see test case "should parse multi-line settings")
Fixes: #1003
How Has This Been Tested?
Unit testing