Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select gist file to upload/download settings #983

Closed
Nipodemos opened this issue Jul 24, 2019 · 16 comments
Closed

Can't select gist file to upload/download settings #983

Nipodemos opened this issue Jul 24, 2019 · 16 comments

Comments

@Nipodemos
Copy link

🐛 Describe the bug
I had already used this a few day ago and worked fine. Now I've formatted my PC and trying to use that awnsome plugin to help. But for some random reason it doesn't appear the option to select the gist (nor to skip and create other)
Downloading a public gist worked fine.

🌴 Visual Studio Code Version : 1.36.1
🌴 Code Settings Sync Version : 3.4.1
🌴 Standard or Insiders : standard
🌴 Portable or Installed : installed
🌴 OSS or Official Build : I don't know, i just downloaded from VS Code website
🌴 Operating System : Windows 10 May 2019 update x64
🌴 Occurs On: First Configuration, when you need to select gist ou skip to create one
🌴 Proxy Enabled: no
🌴 Gist Id: 42eaf2536d1ad0068b0c5421ebb7a4bf

📰 To Reproduce
Steps to reproduce the behavior:

  1. Already have a gist made by settingsSync on other computer
  2. install settingssync on your new computer (or on your PC with a fresh new Windows OS)
  3. notice that when you click "login with github" it will succeed, but then it will have a blank screen

💪 Expected behavior
Select my gist that was already there

📺 Console Error Log
There is no console error

📺 Additional context
image

@shanalikhan
Copy link
Owner

There is no console error

@arnohovhannisyan what do you think ? can you look into it.
Can we improve the exception handling for UI.

@Nipodemos
Copy link
Author

Nipodemos commented Jul 24, 2019

sorry, i must confirm one thing.
I've noticed on other issues that it seems that they look at some developer console of VSCode, i didn't know of this when i posted the issue, i was considering the normal log that is used when we are coding. You want me to test on this developer console to see if something shows up?

i've taken some prints:

before click on login with github

Code_grJsqCuv9h

after clicking:

Code_ZO8bMnWKo1

@Nipodemos
Copy link
Author

Nipodemos commented Jul 24, 2019

strange enough, even if i don't have anything to click, since the gist was already created, it is syncing normally when i use the command shift + alt + u
honestly have no ideia whats goiing on

CODE SETTINGS SYNC UPLOAD SUMMARY
Version: 3.4.1
--------------------
GitHub Token: e2a5425dc069251412b90de2c2070b5597cc4780
GitHub Gist: 1dbc88fb8fe0c3493f042bf25574ce08
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------
Files Uploaded:
  extensions.json > extensions.json
  keybindings.json > keybindings.json
  settings.json > settings.json
  perl.json > snippets\perl.json

Extensions Ignored:
  No extensions ignored.

Extensions Removed:
  No extensions removed.

Extensions Added:
  better-comments v2.0.5
  bracket-pair-colorizer-2 v0.0.28
  bracket-select v2.0.1
  code-settings-sync v3.4.1
  dart-code v3.2.1
  flutter v3.2.0
  flutter-snippets v2.0.0
  pubspec-assist v0.3.6
  vscode-great-icons v2.1.47
  winteriscoming v1.2.0
--------------------
Done.

update:
every time i used the command Reset Extension Settings, and tried to log in to reproduce the bug again, it create another gist, now i have 4 😕
image

@a-wenzel
Copy link

Same here...

1 similar comment
@xyfy
Copy link

xyfy commented Jul 31, 2019

Same here...

@xyfy
Copy link

xyfy commented Jul 31, 2019

I just make my gist public ,after downloaded then delete old and upload a new one

@bmaciag
Copy link

bmaciag commented Aug 3, 2019

same issue here

@jblechinger
Copy link

same issue on windows and ubuntu vsc

@jjnxpct
Copy link

jjnxpct commented Aug 12, 2019

I also had settings sync installed on one PC and uploaded settings to a gist. And today installed it on another PC. Them I loged in with the GitHub button. After that I saw the 'Select you exisitng Gist'.

I went to the syn settings and just entered the (private) Gist ID and that worked. It downloaded the settings and everything seems fine.

sync: Advanced options > Sync:Open settings -> Enter Gist ID on the left.

After the first sync I did have to enter the Gist ID again somehow. Maybe it wasn't saved or something. But after the second time it stayed and I was able to sync OK.

Hope this helps?

@marioarranzr
Copy link

marioarranzr commented Aug 12, 2019

If you set the gistID in configuration page and then restart VSCode, then it works and it is also available view button

@tolgabalci
Copy link

tolgabalci commented Aug 14, 2019

I just installed vscode 1.37.0 on a new machine, and had this same issue. I just get "Select Your Existing Gist" and nothing is shown below it. I pressed Alt+Shift+U and a new gist was created. I had to go Edit Configuration and set the gist id manually to the correct (prior) gist. Then doing Ctrl+Shift+D worked, but it was a troubling experience. (no VSCode restart was required for me)

@jjnxpct
Copy link

jjnxpct commented Aug 15, 2019

I think you have to add the Gist ID of your existing Gist before any sync actions. But I agree this is not very clear. Setting the Sync up on the first machine is pretty easy. But setting it up on an second machine to sync the first with is less obvious.

shanalikhan added a commit that referenced this issue Aug 20, 2019
@shanalikhan shanalikhan added this to the v3.4.2 milestone Aug 20, 2019
@shanalikhan
Copy link
Owner

It is fixed. Will be released in next version.

Setting the Sync up on the first machine is pretty easy. But setting it up on an second machine to sync the first with is less obvious.

@jjnxpct Do you have any ideas in mind to improve the UX for second machine ? If its regarding the wiki, I would appreciate a PR improving that (and will release with next version) else you can open new issue so i can look into it in upcoming versions.

@jjnxpct
Copy link

jjnxpct commented Aug 21, 2019

@shanalikhan I need to set up VSCode on another machine sometime in the next few weeks. I will try to remember to write down what is unclear and could be improved. I think maybe some more text to explain what to do on first setup and what to do if you already have set up on a different machine.

@shanalikhan
Copy link
Owner

It is fixed and released in v3.4.2

shanalikhan added a commit that referenced this issue Aug 22, 2019
* Fix korean

* Fix: Ambiguous Expression and Korean naturally

* Missing keys

* Change `Sync :` to `Sync:`

* dev.to post updated

* #989

* Update package.nls.ko.json

fixing some wrong translate.

* Update ko-lang

Although translated, it some case may not be accurate.

* Fix GitHub spelling

* chore(package): update @types/chai to version 4.2.0

* Update french translation file

* Correcting the german translation

Checking the translation based on the package.nls.json file
Correcting the grammar for the german translation

* Correcting typos

Correcting spelling mistakes and typos

* Correcting spelling mistakes

Correcting more spelling mistakes

* #974

* #977
#989

* #1003 (#1012)

Also fix errors with settings containing backslashes.

* #983

* #1008
@filviu
Copy link

filviu commented Aug 29, 2019

Same behaviour for me with fresh install, Sync 3.4.2 and VSCode 1.37.1

After GitHub Login I get a page to select existing Gist with no skip option.

If I upload then on each upload a new gist is created. I suspect that manually picking up the id of one of them and entering it into settings will work.

EDIT: on a second try (uninstall extension, login again) even if no skip button was there I could Upload settings and it created a gist and added the ID automatically in settings so now it syncs to the same gist, doesn't create multiple ones. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants