Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hono icon #10140

Merged
merged 9 commits into from
Dec 20, 2023
Merged

Add Hono icon #10140

merged 9 commits into from
Dec 20, 2023

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Dec 17, 2023

image

Similarweb rank: 454,247
GitHub Stars: 9,273

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hono is a web framework for the Edges. It works on any JavaScript runtime.

#FF612B is defined by @yusukebe(creator of Hono) on Discord community.
This icon is made manually based on https://github.com/honojs/hono.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 17, 2023
@adamrusted
Copy link
Member

We do have an SVG available at https://github.com/honojs/hono/blob/76dbc74407329c46870af6aa4fab0c04036d8ae2/docs/images/hono-logo.svg. Should probably use this URL as our source.

adamrusted
adamrusted requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Multiple differences when comparing with the SVG available in their repo. Can you please re-work this using the SVG as source @ryuapp?

@ryuapp
Copy link
Contributor Author

ryuapp commented Dec 18, 2023 •
edited

image
I fixed Hono icon based on https://github.com/honojs/hono/blob/76dbc74407329c46870af6aa4fab0c04036d8ae2/docs/images/hono-logo.svg.

PeterShaggyNoble
PeterShaggyNoble requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @ryuapp, but I'm noticing some differences when comparing with the source SVG Adam linked above - here's an example, with your version in black. Would you mind having another look at this, please?

Also, the website's stylesheet variables refer to #E36002 as --vp-c-brand-1, so I think that's the colour we should run with here.

@adamrusted adamrusted removed their request for review December 19, 2023 16:01
@ryuapp
Copy link
Contributor Author

ryuapp commented Dec 19, 2023 •
edited

@PeterShaggyNoble
Thanks for reviewing. I fixed it.
I learned to convert multiple paths into one single path.

I confirmed theme color with author of Hono by Discord.
#E36002 was one of the candidates, but he selected #FF612B.
If there are any rules in this repo, I'll follow them.

@PeterShaggyNoble
Copy link
Member

I confirmed the color(#FF612B) with author of Hono by Discord.
If there are any rules in this repo, I'll follow them.

One of our most important rules is that feedback from official sources overrules all other rules! 😆 So, #FF612B is therefore the correct choice here.

PeterShaggyNoble
PeterShaggyNoble requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing a small difference down the right edge, @ryuapp - it looks like an additional point was introduced in the top corner somewhere along the way that might be causing the issue.

@ryuapp
Copy link
Contributor Author

ryuapp commented Dec 19, 2023

@PeterShaggyNoble
Thank you to update source URL.
I fixed the icon.
I focused to centering and resizing and double check for any difference.

PeterShaggyNoble
PeterShaggyNoble approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me now, @ryuapp 👍🏻 Nice work.

@PeterShaggyNoble PeterShaggyNoble merged commit c5ab8d9 into simple-icons:develop Dec 20, 2023
3 checks passed
@ryuapp ryuapp deleted the add-hono branch December 20, 2023 16:11
@ryuapp ryuapp mentioned this pull request Dec 20, 2023
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Dec 24, 2023
Merged
mondeja added a commit that referenced this pull request Dec 24, 2023
@mondeja
Release 21 new icons and 6 updated icons (v10.4.0)
f573581 
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryuapp @adamrusted @PeterShaggyNoble