Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamRunners' icon #10157

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Add StreamRunners' icon #10157

merged 8 commits into from
Dec 20, 2023

Conversation

Ionys320
Copy link
Contributor

Issue: closes #10149

Similarweb rank:

Similar Web Rank World: 376,599
Similar Web Rank French: 14,488

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Used the official StreamRunners' icon and hex color as I am the main developer of the project.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 19, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Ionys320 👍🏻 The SVG lines up perfectly for me but it does include a few excess points, also present in the source, that could be removed. Can you give that a try, please?

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
Ionys320 and others added 2 commits December 20, 2023 12:54
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@Ionys320
Copy link
Contributor Author

Hey @PeterShaggyNoble! Both changes have been made 👌🏻

@Ionys320
Copy link
Contributor Author

I'm not sure about the excess points of the SVG you're talking about. I don't really works with SVG editors, therefore I'm not sure if I can fix this by myself.

@PeterShaggyNoble
Copy link
Member

The 3 points highlighted in blue/red below can be removed without affecting the integrity of the SVG. There are a few overlapping ones in the bottom left corner that could probably be removed, too.

@Ionys320
Copy link
Contributor Author

Indeed, I removed the four points you were talking about! Optimized the SVG after the edit as usual.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍🏻Nice work, @Ionys320, thanks for the contribution.

Once you've updated your branch then I'll merge this in.

@Ionys320
Copy link
Contributor Author

You're welcome @PeterShaggyNoble !

@PeterShaggyNoble PeterShaggyNoble merged commit 8881aa4 into simple-icons:develop Dec 20, 2023
3 checks passed
mondeja added a commit that referenced this pull request Dec 24, 2023
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamRunners Icons
2 participants