Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Piped #9284

Merged
merged 21 commits into from
Dec 21, 2023
Merged

Add Piped #9284

merged 21 commits into from
Dec 21, 2023

Conversation

SebiTalent04
Copy link
Contributor

@SebiTalent04 SebiTalent04 commented Aug 13, 2023

No description provided.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 13, 2023
@adamrusted
Copy link
Member

Ooh this is a fun one!
Personally, I'd add a gap between the two areas of the pipe, as below
image

What would other @simple-icons/icon-review folk recommend?

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give it another try @SebiTalent04

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/piped.svg Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@PratyushJayachandran PratyushJayachandran added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Sep 17, 2023
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @SebiTalent04?

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 13, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran, I'm seeing some differences in the inner edge of all 3 ovals (example from the topmost one, with yours in red). There are also a number of excess points that could be removed.

@PratyushJayachandran
Copy link
Member

@PeterShaggyNoble
piped

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give this a try, @PratyushJayachandran; managed to remove a few of the excess points - man, but the outer curve is riddled with imperfections! - and get the precision down to 3. Do a quick comparison yourself, though, in case I missed anything.

M9.947 22.915c0 .6-1.207 1.085-2.7 1.085-1.492 0-2.698-.485-2.698-1.085s1.206-1.086 2.699-1.086c1.492 0 2.699.485 2.699 1.086zm-.018-.906V.789S9.593.58 9.06.33A7.333 7.333 0 0 0 8.1.07 8.257 8.257 0 0 0 6.986 0a8.07 8.07 0 0 0-1.043.144c-.305.085-.572.18-.786.272A5.819 5.819 0 0 0 4.56.79v21.223c.609-.462 1.668-.684 2.687-.684 1.015 0 2.072.22 2.68.68zm1.906-17.195c.66 0 1.192-1 1.192-2.237S12.494.34 11.835.34c-.66 0-1.192 1-1.192 2.237s.533 2.237 1.192 2.237zm.045 4.488c-.66 0-1.192 1.102-1.192 2.464 0 1.363.533 2.465 1.192 2.465.66 0 1.192-1.102 1.192-2.465 0-1.362-.532-2.464-1.192-2.464zm7.556-2.16a12.19 12.19 0 0 0-.142-1.026 12.28 12.28 0 0 0-.27-.994 12.027 12.027 0 0 0-.388-.939c-.151-.293-.315-.58-.492-.859a10.837 10.837 0 0 0-.578-.76 10.181 10.181 0 0 0-.647-.65 9.626 9.626 0 0 0-1.412-.941 9.61 9.61 0 0 0-1.412-.492 10.987 10.987 0 0 0-.65-.102 6.299 6.299 0 0 0-.626-.053c.433.486.708 1.294.708 2.25 0 1-.3 1.836-.767 2.313.224.041.575.163.708.212.215.096.432.211.641.344.356.258.543.471.73.77.263.474.31.856.247 1.287-.135.651-.495 1.035-.937 1.33a4.3 4.3 0 0 1-.623.297c-.087.026-.438.13-.694.158.453.521.74 1.418.74 2.48 0 1.042-.278 1.923-.716 2.448.114-.002.22-.003.35-.007.414-.037.9-.107 1.395-.207.314-.085.862-.25 1.531-.55a8.856 8.856 0 0 0 1.422-.996c.213-.214.415-.438.605-.673a8.95 8.95 0 0 0 .504-.782c.145-.285.275-.577.39-.876.102-.308.19-.626.262-.951.058-.33.1-.664.129-1.003.02-.343-.001-.686-.008-1.028z

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your SVG @PeterShaggyNoble

icons/piped.svg Outdated Show resolved Hide resolved
@adamrusted adamrusted dismissed stale reviews from PratyushJayachandran and PeterShaggyNoble December 21, 2023 13:35

Contributed

@adamrusted adamrusted merged commit 86eeb76 into simple-icons:develop Dec 21, 2023
3 checks passed
mondeja added a commit that referenced this pull request Dec 24, 2023
# New Icons

- Afterpay (#10164)
- AutoIt (#10154)
- Barmenia (#10134)
- BitTorrent (#9564)
- Bluesky (#8856)
- Brex (#10130)
- Calendly (#10145)
- Deutsche Post (#10131)
- Galaxus (#10132)
- Google Campaign Manager 360 (#10005)
- Hono (#10140)
- Hostinger (#10141)
- Les libraires (#10160)
- Meituan (#10126)
- NextDNS (#9150)
- Paddle (#10135)
- Piped (#9284)
- SeatGeek (#10139)
- StreamRunners (#10157)
- Transifex (#10133)
- Transmission (#9566)

# Updated Icons

- Kdenlive (#10179)
- Photobucket (#10161)
- Roblox (#10162)
- Roblox Studio (#10162)
- Write.as (#10151)
- ŠKODA (#10167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants