[python/ci] Factor pytest.fixtures, verify #1988
#2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
===========================================
+ Coverage 78.68% 90.35% +11.67%
===========================================
Files 140 37 -103
Lines 10767 3899 -6868
Branches 215 0 -215
===========================================
- Hits 8472 3523 -4949
+ Misses 2197 376 -1821
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
This is epic -- thank you!
I didn't set an expectation ahead of time, but for the future: let's do refactor PRs and behavior-addition PRs as separate. That makes them easier to review. (And easier to deal with in case of reverts, which admittedly don't often happen.)
johnkerl
pushed a commit
that referenced
this pull request
Mar 22, 2024
* typeguard nit missed in #1960 * factor common fixtures into conftest.py * factor test_update_dataframes fixture * `verify_obs_var` helper, more `test_update_dataframes` factoring * test_experiment_query.py: verify #1988 * `s/h5ad_file/h5ad_path/g`, factor `HERE`s Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
johnkerl
changed the title
pytest.fixtures, verify #1988pytest.fixtures, verify #1988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #1988
Changes:
pytest.fixtures, misc test cleanupNotes for Reviewer:
test_empty_categorical_query, raisesArrowInvalidwith TileDB 2.20.1, but passes here with 2.21.0.