Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip test_empty_categorical_query #2307

Closed
wants to merge 1 commit into from
Closed

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Mar 22, 2024

Skip test added in #2299 which requires core 2.21.0, and is currently failing builds release-1.8 builds (example).

Issue and/or context: #1988, #2299

requires core 2.21.0, not always guaranteed
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #2307 (f1eedbe) into release-1.8 (dc79b35) will increase coverage by 18.45%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.8    #2307       +/-   ##
================================================
+ Coverage        72.10%   90.55%   +18.45%     
================================================
  Files              103       37       -66     
  Lines             6875     3875     -3000     
  Branches           215        0      -215     
================================================
- Hits              4957     3509     -1448     
+ Misses            1820      366     -1454     
+ Partials            98        0       -98     
Flag Coverage Δ
libtiledbsoma ?
python 90.55% <ø> (?)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.55% <ø> (∅)
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member

Replaced by #2308

@johnkerl johnkerl closed this Mar 22, 2024
@ryan-williams ryan-williams deleted the rw/2299-skip-1.8 branch June 17, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants