Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Make test_empty_categorical_query work with TileDB<2.21 #2308

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Mar 22, 2024

Issue and/or context: #2299, #1988, #2307

Test now verifies that:

  • TileDB<2.21 ⟹ ArrowInvalid raised
  • TileDB>=2.21 ⟹ [] returned

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #2308 (00a7353) into main (17b694a) will increase coverage by 11.87%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2308       +/-   ##
===========================================
+ Coverage   78.70%   90.58%   +11.87%     
===========================================
  Files         140       37      -103     
  Lines       10756     3875     -6881     
  Branches      215        0      -215     
===========================================
- Hits         8466     3510     -4956     
+ Misses       2191      365     -1826     
+ Partials       99        0       -99     
Flag Coverage Δ
libtiledbsoma ?
python 90.58% <ø> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.58% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review March 22, 2024 19:03
@johnkerl johnkerl merged commit 3346005 into main Mar 22, 2024
12 checks passed
@johnkerl johnkerl deleted the rw/2299catch branch March 22, 2024 20:01
johnkerl pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
@johnkerl johnkerl changed the title Make test_empty_categorical_query work with TileDB<2.21 [python] Make test_empty_categorical_query work with TileDB<2.21 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants