Fixes #1131 improve view_submission listener documents #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 15 15
Lines 1354 1354
Branches 402 402
=======================================
Hits 971 971
Misses 312 312
Partials 71 71 Continue to review full report at Codecov.
|
seratch
requested changes
Oct 13, 2021
docs/_basic/ja_listening_modals.md
Outdated
|
|
||
| <code>view()</code> メソッドは、文字列型または <code>RegeExp</code>型 の <code>callback_id</code> を必要とします。 | ||
| `view()` メソッドは、文字列型または `RegExp`型 の `callback_id` を必要とします。 |
There was a problem hiding this comment.
Can you always have a space before/after backtick?
Suggested change
| `view()` メソッドは、文字列型または `RegExp`型 の `callback_id` を必要とします。 | |
| `view()` メソッドは、文字列型または `RegExp` 型 の `callback_id` を必要とします。 |
docs/_basic/ja_listening_modals.md
Outdated
|
|
||
| `view_submission` リクエストに対してモーダルを更新するには、`update`型の `response_action` と新しく作成した `view` を指定すると確認を示します。 | ||
|
|
||
| `view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` を指定した `response_action` と新しく作成した `view` を指定します。 |
There was a problem hiding this comment.
As I mentioned in slackapi/bolt-python#494, we would like to avoid repeating 指定する in a sentence.
Suggested change
| `view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` を指定した `response_action` と新しく作成した `view` を指定します。 | |
| `view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` という `response_action` と新しく作成した `view` を指定します。 |
docs/_basic/ja_listening_modals.md
Outdated
|
|
||
| ##### モーダル送信でのビューの更新 | ||
|
|
||
| `view_submission` リクエストに対してモーダルを更新するには、`update`型の `response_action` と新しく作成した `view` を指定すると確認を示します。 |
There was a problem hiding this comment.
It seems that this line should be removed
Suggested change
| `view_submission` リクエストに対してモーダルを更新するには、`update`型の `response_action` と新しく作成した `view` を指定すると確認を示します。 |
seratch
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1131. Adding information on what to do on
view_submission.Requirements (place an
xin each[ ])