Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string split in glyco protein parsimony #2305

Merged
merged 14 commits into from
Sep 7, 2023

Conversation

trishorts
Copy link
Contributor

Some protein accessions contain hyphens. These unexpected hyphens cause a crash in string.split functions for hyphen. This PR replaces the hyphen with the hashtag eliminating the crash.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2305 (16ee6e7) into master (20713d6) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 95.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files         135      135           
  Lines       20644    20644           
  Branches     2841     2842    +1     
=======================================
  Hits        19025    19025           
  Misses       1134     1134           
  Partials      485      485           
Files Changed Coverage Δ
MetaMorpheus/TaskLayer/XLSearchTask/WriteFile.cs 97.74% <94.44%> (ø)
...TaskLayer/GlycoSearchTask/GlycoProteinParsimony.cs 76.36% <100.00%> (ø)
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc).

@trishorts trishorts merged commit b160b85 into smith-chem-wisc:master Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants