-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fire an error event on middleware failure for non-root namespace #1202
Merged
darrachequesne
merged 1 commit into
socketio:master
from
darrachequesne:fix/middleware-auth
May 17, 2018
Merged
fix: fire an error event on middleware failure for non-root namespace #1202
darrachequesne
merged 1 commit into
socketio:master
from
darrachequesne:fix/middleware-auth
May 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following example: ```js io.use((socket, next) => { next(new Error('Auth failed')); }); // client-side const socket = io('https://url/custom-namespace'); socket.on('error', (err) => { // ... }); ``` The 'error' event wasn't fired on the custom namespace.
darrachequesne
added a commit
that referenced
this pull request
May 17, 2018
#1202) In the following example: ```js io.use((socket, next) => { next(new Error('Auth failed')); }); // client-side const socket = io('https://url/custom-namespace'); socket.on('error', (err) => { // ... }); ``` The 'error' event wasn't fired on the custom namespace.
This was referenced Sep 22, 2018
This was referenced Jan 23, 2020
This was referenced Mar 13, 2020
This was referenced May 29, 2021
This was referenced Jun 6, 2021
This was referenced Dec 7, 2021
1 task
This was referenced Feb 4, 2022
Closed
1 task
1 task
1 task
1 task
1 task
This was referenced Jun 27, 2022
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
In the following example:
The 'error' event wasn't fired on the custom namespace.
New behaviour
The event is now fired.
Other information (e.g. related issues)
Related: