Add stackHeight to the instruction type
#2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ebf596 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
commented
Jun 27, 2024
Comment on lines
40
to
55
| export const instructionConfig = [['accounts', KEYPATH_WILDCARD], ['programIdIndex'], ['stackHeight']]; | ||
| export const innerInstructionsConfigs = [ | ||
| ['index'], | ||
| ...instructionConfig.map(c => ['instructions', KEYPATH_WILDCARD, ...c]), | ||
| ]; | ||
| export const messageConfig = [ | ||
| ['addressTableLookups', KEYPATH_WILDCARD, 'writableIndexes', KEYPATH_WILDCARD], | ||
| ['addressTableLookups', KEYPATH_WILDCARD, 'readonlyIndexes', KEYPATH_WILDCARD], | ||
| ...instructionConfig.map(c => ['instructions', KEYPATH_WILDCARD, ...c]), | ||
| ['header', 'numReadonlySignedAccounts'], | ||
| ['header', 'numReadonlyUnsignedAccounts'], | ||
| ['header', 'numRequiredSignatures'], | ||
| ] as const; |
There was a problem hiding this comment.
Did a little compressing of the configuration that prevents bigint upcasts for certain values, while also adding stackHeight to the list. Please go over with a fine-toothed comb in case I missed anything.
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
251f9ab
to
8c2dd82
Compare
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
8c2dd82
to
05a31bf
Compare
steveluscher
force-pushed
the
06-27-correct_the_return_type_of_simulatetransaction_when_accounts_are_not_loaded
branch
from
f1baa9e
to
5bb7d21
Compare
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
05a31bf
to
c5e569f
Compare
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
c5e569f
to
ef54325
Compare
steveluscher
commented
Jun 27, 2024
Comment on lines
+52
to
+54
| ['instructions', KEYPATH_WILDCARD, 'accounts', KEYPATH_WILDCARD], | ||
| ['instructions', KEYPATH_WILDCARD, 'programIdIndex'], | ||
| ['instructions', KEYPATH_WILDCARD, 'stackHeight'], |
There was a problem hiding this comment.
Would have DRY'd these up too, but using foo.map() in this file at the top level would break tree-shakability.
Base automatically changed from
06-27-correct_the_return_type_of_simulatetransaction_when_accounts_are_not_loaded
to
master
June 28, 2024 00:18
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
ef54325
to
f7d6ec2
Compare
buffalojoec
approved these changes
Jun 28, 2024
Merge activity
|
steveluscher
force-pushed
the
06-27-add_stackheight_to_the_instruction_type
branch
from
f7d6ec2
to
3ebf596
Compare
|
🎉 This PR is included in version 1.94.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See solana-labs/solana#28430