Add replacementBlockhash to the simulation return type, in preparation for Agave 2.0
#2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
steveluscher
force-pushed
the
06-27-add_replacementblockhash_to_the_simulation_return_type_in_preparation_for_agave_2.0
branch
from
f42fed6
to
a8d46c8
Compare
This was referenced Jun 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
force-pushed
the
06-27-add_replacementblockhash_to_the_simulation_return_type_in_preparation_for_agave_2.0
branch
from
a8d46c8
to
a7187f8
Compare
steveluscher
force-pushed
the
06-27-you_can_now_request_innerinstructions_with_simulation
branch
from
7c30ca8
to
8cc8346
Compare
steveluscher
force-pushed
the
06-27-add_replacementblockhash_to_the_simulation_return_type_in_preparation_for_agave_2.0
branch
from
a7187f8
to
07a10c8
Compare
buffalojoec
approved these changes
Jun 28, 2024
Comment on lines
+95
to
+99
| // TODO(https://github.com/solana-labs/solana-web3.js/issues/2869): Make it so that | ||
| // `replacementBlockhash` only appears on the return type when `replaceRecentBlockhash` is set | ||
| // to `true` in the call to `simulateTransaction`. | ||
| /** The blockhash that was used to simulate the transaction when `replaceRecentBlockhash` is `true` */ | ||
| replacementBlockhash?: Blockhash; |
Merge activity
|
steveluscher
force-pushed
the
06-27-you_can_now_request_innerinstructions_with_simulation
branch
from
8cc8346
to
5fa6c60
Compare
Base automatically changed from
06-27-you_can_now_request_innerinstructions_with_simulation
to
master
June 28, 2024 00:39
…ion for Agave 2.0
steveluscher
force-pushed
the
06-27-add_replacementblockhash_to_the_simulation_return_type_in_preparation_for_agave_2.0
branch
from
07a10c8
to
c99533c
Compare
steveluscher
deleted the
06-27-add_replacementblockhash_to_the_simulation_return_type_in_preparation_for_agave_2.0
branch
|
🎉 This PR is included in version 1.94.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you ask the simulator to
replaceRecentBlockhash, you may like to know what the replacement blockhash was. Agave 2.0 will return it in the simulation result.It would have been nice to only include this property when
replaceRecentBlockhashis explicitlytrue, but I would have had to duplicate all of the overloads for the purpose, yielding 32 in total.