Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the type of innerInstructions in JSON RPC errors #2867

Conversation

steveluscher
Copy link
Collaborator

These names are camel-cased. This can't be imported from @solana/rpc-types because @solana/errors must be zero dependency.

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 1d55a13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@solana/errors Patch
@solana/accounts Patch
@solana/addresses Patch
@solana/assertions Patch
@solana/codecs-core Patch
@solana/codecs-data-structures Patch
@solana/codecs-numbers Patch
@solana/codecs-strings Patch
@solana/compat Patch
@solana/instructions Patch
@solana/keys Patch
@solana/web3.js-experimental Patch
@solana/options Patch
@solana/programs Patch
@solana/react Patch
@solana/rpc-api Patch
@solana/rpc-spec Patch
@solana/rpc-subscriptions-spec Patch
@solana/rpc-subscriptions-transport-websocket Patch
@solana/rpc-subscriptions Patch
@solana/rpc-transport-http Patch
@solana/rpc-types Patch
@solana/rpc Patch
@solana/signers Patch
@solana/sysvars Patch
@solana/transaction-confirmation Patch
@solana/transaction-messages Patch
@solana/transactions Patch
@solana/rpc-graphql Patch
@solana/rpc-parsed-types Patch
@solana/rpc-subscriptions-api Patch
@solana/codecs Patch
@solana/rpc-transformers Patch
@solana/fast-stable-stringify Patch
@solana/functional Patch
@solana/rpc-spec-types Patch
@solana/webcrypto-ed25519-polyfill Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@steveluscher steveluscher force-pushed the 06-27-add_stackheight_to_the_instruction_type branch from 8c2dd82 to 05a31bf Compare June 27, 2024 19:36
@steveluscher steveluscher force-pushed the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch from 365b4ae to 99f1d1d Compare June 27, 2024 19:36
@steveluscher steveluscher force-pushed the 06-27-add_stackheight_to_the_instruction_type branch from 05a31bf to c5e569f Compare June 27, 2024 21:33
@steveluscher steveluscher force-pushed the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch from 99f1d1d to e40a06c Compare June 27, 2024 21:33
@steveluscher steveluscher force-pushed the 06-27-add_stackheight_to_the_instruction_type branch from c5e569f to ef54325 Compare June 27, 2024 21:41
@steveluscher steveluscher force-pushed the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch from e40a06c to e06c2fd Compare June 27, 2024 21:41
@steveluscher steveluscher force-pushed the 06-27-add_stackheight_to_the_instruction_type branch from ef54325 to f7d6ec2 Compare June 28, 2024 00:20
@steveluscher steveluscher force-pushed the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch from e06c2fd to fd7152b Compare June 28, 2024 00:20
Copy link
Collaborator Author

steveluscher commented Jun 28, 2024

Merge activity

  • Jun 27, 5:34 PM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Jun 27, 5:36 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 27, 5:37 PM PDT: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 06-27-add_stackheight_to_the_instruction_type branch from f7d6ec2 to 3ebf596 Compare June 28, 2024 00:34
Base automatically changed from 06-27-add_stackheight_to_the_instruction_type to master June 28, 2024 00:35
@steveluscher steveluscher force-pushed the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch from fd7152b to 1d55a13 Compare June 28, 2024 00:35
@steveluscher steveluscher merged commit be36bab into master Jun 28, 2024
6 checks passed
@steveluscher steveluscher deleted the 06-27-correct_the_type_of_innerinstructions_in_json_rpc_errors branch June 28, 2024 00:37
Copy link
Contributor

🎉 This PR is included in version 1.94.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants