Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device config] Adding configuration for default route fallback #10465

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

Ndancejic
Copy link
Contributor

@Ndancejic Ndancejic commented Apr 4, 2022

Why I did it:

Set sai_tunnel_underlay_route_mode attribute to fallback to default route if more specific route is unavailable.

How I did it:

Added the configuration option: sai_tunnel_underlay_route_mode=1 in
device\arista\x86_64-arista_7050cx3_32s
Arista-7050CX3-32S-C32\td3-a7050cx3-32s-32x100G.config.bcm

How to verify it:

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Adding configuration for default route fallback

@Ndancejic
Copy link
Contributor Author

Tests are failing because of this error message:
[line 8] Error: sai_tunnel_underlay_route_mode is not permitted

@prsunny
Copy link
Contributor

prsunny commented Apr 5, 2022

Please add the attribute to permitted list

@@ -5,6 +5,7 @@ host_as_route_disable=1
use_all_splithorizon_groups=1
riot_enable=1
sai_tunnel_support=1
sai_tunnel_underlay_route_mode=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the attribute to other relevant config files as well

Set sai_tunnel_underlay_route_mode attribute to fallback to default
route if more specific route is unavailable.
@Ndancejic Ndancejic requested a review from lguohan as a code owner April 5, 2022 20:30
@Ndancejic Ndancejic changed the title [7050CX3-32S-C32] Adding configuration for default route fallback [device config] Adding configuration for default route fallback Apr 5, 2022
@prsunny prsunny merged commit f2acf95 into sonic-net:master Apr 12, 2022
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@prsunny
Copy link
Contributor

prsunny commented Apr 26, 2022

@Ndancejic , can you please raise a separate PR for 202012?

liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants