[yang]: Add yang model for MACsec #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
Build failed, please add yang model to setup.py |
|
Please update tests/files/sample_config_db.json |
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Done |
ganglyu
reviewed
Apr 13, 2022
src/sonic-yang-models/setup.py
Outdated
| @@ -143,7 +143,8 @@ def run(self): | |||
| './yang-models/sonic-tc-queue-map.yang', | |||
| './yang-models/sonic-pfc-priority-queue-map.yang', | |||
| './yang-models/sonic-pfc-priority-priority-group-map.yang', | |||
| './yang-models/sonic-port-qos-map.yang']), | |||
| './yang-models/sonic-port-qos-map.yang', | |||
| './yang-models/sonic-macsec.yang',]), | |||
There was a problem hiding this comment.
Would you please remove the ','
ganglyu
reviewed
Apr 13, 2022
|
|
||
| leaf enable_replay_protect { | ||
| type string { | ||
| pattern "true|false"; |
There was a problem hiding this comment.
ganglyu
requested review from
praveen-li,
rathnasabapathyv,
venkatmahalingam and
dgsudharsan
Signed-off-by: Ze Gan <ganze718@gmail.com>
ganglyu
previously approved these changes
Apr 14, 2022
Signed-off-by: Ze Gan <ganze718@gmail.com>
qiluo-msft
approved these changes
Apr 14, 2022
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add Yang model to constrain the configuration of MACsec
How I did it
Add Yang model for MACsec configuration and its testcases
How to verify it
Check Azp status
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
https://github.com/Azure/SONiC/blob/master/doc/macsec/MACsec_hld.md#31-config-db
A picture of a cute animal (not mandatory but encouraged)