Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add startup dependency on swss for teamd #2187

Closed
wants to merge 2 commits into from
Closed

Add startup dependency on swss for teamd #2187

wants to merge 2 commits into from

Conversation

jipanyang
Copy link
Collaborator

@jipanyang jipanyang commented Oct 24, 2018 •
edited
Loading

Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com

- What I did
Let teamd start after swss, as swss will flush the whole stateDB upon cold start.

This is a try to address issue #2186

- How I did it

- How to verify it

Do system reboot, state information for LAG in stateDB get created and preserved properly.

admin@sonic:~$ teamshow
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available, S - selected, D - deselected
  No.  Team Dev       Protocol     Ports
-----  -------------  -----------  -------------
    1  PortChannel1   LACP(A)(Dw)  Ethernet1(D)
    2  PortChannel2   LACP(A)(Up)  Ethernet2(S)
    3  PortChannel3   LACP(A)(Up)  Ethernet3(S)
    4  PortChannel4   LACP(A)(Dw)  Ethernet4(D)
    5  PortChannel5   LACP(A)(Dw)  Ethernet5(D)
    6  PortChannel6   LACP(A)(Dw)  Ethernet6(D)
    7  PortChannel7   LACP(A)(Dw)  Ethernet7(D)
    8  PortChannel8   LACP(A)(Dw)  Ethernet8(D)
    9  PortChannel9   LACP(A)(Dw)  Ethernet9(D)
   10  PortChannel10  LACP(A)(Dw)  Ethernet10(D)
   11  PortChannel11  LACP(A)(Dw)  Ethernet11(D)
   12  PortChannel12  LACP(A)(Dw)  Ethernet12(D)
   13  PortChannel13  LACP(A)(Dw)  Ethernet13(D)
   14  PortChannel14  LACP(A)(Dw)  Ethernet14(D)
   15  PortChannel15  LACP(A)(Dw)  Ethernet15(D)
   16  PortChannel16  LACP(A)(Dw)  Ethernet16(D)
   17  PortChannel17  LACP(A)(Dw)  Ethernet17(D)
   18  PortChannel18  LACP(A)(Dw)  Ethernet18(D)
   19  PortChannel19  LACP(A)(Dw)  Ethernet19(D)
   20  PortChannel20  LACP(A)(Dw)  Ethernet20(D)
admin@sonic:~$ redis-cli -n 6
127.0.0.1:6379[6]> keys LAG*
 1) "LAG_TABLE|PortChannel18"
 2) "LAG_TABLE|PortChannel7"
 3) "LAG_TABLE|PortChannel1"
 4) "LAG_TABLE|PortChannel16"
 5) "LAG_TABLE|PortChannel19"
 6) "LAG_TABLE|PortChannel15"
 7) "LAG_TABLE|PortChannel17"
 8) "LAG_TABLE|PortChannel5"
 9) "LAG_TABLE|PortChannel9"
10) "LAG_TABLE|PortChannel8"
11) "LAG_TABLE|PortChannel6"
12) "LAG_TABLE|PortChannel13"
13) "LAG_TABLE|PortChannel2"
14) "LAG_TABLE|PortChannel4"
15) "LAG_TABLE|PortChannel3"
16) "LAG_TABLE|PortChannel14"
17) "LAG_TABLE|PortChannel11"
18) "LAG_TABLE|PortChannel10"
19) "LAG_TABLE|PortChannel20"
20) "LAG_TABLE|PortChannel12"

- Description for the changelog

@jipanyang
Add startup dependency on swss for teamd
4bf0bde 
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
@lguohan lguohan requested a review from stcheng October 24, 2018 03:55
@jipanyang
Don't restart teamd upon swss restart, for case of swss warm restart
166a394 
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
@stcheng
Copy link
Contributor

stcheng commented Nov 1, 2018

Instead of having a dependency for swss, it is better to clean up the state database separately according to the contents. This pull request resolves this issue: #2223

stcheng
stcheng suggested changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check #2223

@lguohan lguohan closed this Nov 2, 2018
saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this pull request Apr 5, 2022
@saiarcot895
[sonic-swss]: Update submodule
ea2e2db 
This submodule update brings in the following changes:

```
50d5be2 Make changes to support compiling on Bullseye with GCC 10 (sonic-net#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (sonic-net#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (sonic-net#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
5575935 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
0f06910 [PBH] Implement Edit Flows (sonic-net#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (sonic-net#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (sonic-net#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (sonic-net#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (sonic-net#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (sonic-net#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
2bef62b Validate LAG has members before mirror session create (sonic-net#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (sonic-net#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (sonic-net#2179)
```

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
theasianpianist added a commit to theasianpianist/sonic-buildimage that referenced this pull request Apr 6, 2022
@theasianpianist
[swss]: Submodule update:
81a746a 
50d5be2 (HEAD, origin/master, origin/HEAD) Make changes to support compiling on Bullseye with GCC 10 (sonic-net#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (sonic-net#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (sonic-net#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
5575935 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
0f06910 (master) [PBH] Implement Edit Flows (sonic-net#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (sonic-net#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (sonic-net#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (sonic-net#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (sonic-net#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (sonic-net#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
2bef62b Validate LAG has members before mirror session create (sonic-net#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (sonic-net#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (sonic-net#2179)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
liat-grozovik pushed a commit that referenced this pull request Apr 7, 2022
@nazariig
[submodule] Advance sonic-swss submodule. (#10404)
16717d2 
In order to include the following commit:
0f06910 [PBH] Implement Edit Flows (sonic-net/sonic-swss#2169)

sonic-swss

50d5be2 Make changes to support compiling on Bullseye with GCC 10 (#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (#2206)
5575935 [neighsyncd] increase neighsyncd timeout (#2209)
0f06910 [PBH] Implement Edit Flows (#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (#2191)
2bef62b Validate LAG has members before mirror session create (#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (#2179)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
judyjoseph added a commit that referenced this pull request Apr 11, 2022
@judyjoseph
Update submodule
b49e04a 
dd0fb84 (HEAD -> 202111, origin/202111) [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (#2187)
Ndancejic pushed a commit to Ndancejic/sonic-buildimage that referenced this pull request May 3, 2022
@nazariig
[mirrororch]: Implement HW resources availability validation for SPAN…
0870cf5 
…/ERSPAN (sonic-net#2187)

- What I did
Added a validation to prevent mirror session configuration if there is no available HW resources

- Why I did it
To prevent system from unexpected reboots
To add some debuggability information to the system journal

- How I verified it
Configure mirror sessions

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6004325: Manual merge github master to internal
19c4542 
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng requested changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jipanyang @stcheng @lguohan