Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] minor improvements to Index tests #1900

Merged
merged 52 commits into from
Mar 29, 2022
Merged

[MRG] minor improvements to Index tests #1900

merged 52 commits into from
Mar 29, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 26, 2022

This PR:

  • properly handles JSON parsing errors in MultiIndex.load_from_directory;
  • adds a simpler test of that bad JSON raise;
  • updates comments, simplifies tests.

@ctb ctb changed the title [WIP] minor improvements to Index tests [WIP] minor improvements to Index tests Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1900 (68c7edb) into latest (c26ac4e) will increase coverage by 7.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1900      +/-   ##
==========================================
+ Coverage   82.82%   90.73%   +7.90%     
==========================================
  Files         122       92      -30     
  Lines       13254     9052    -4202     
  Branches     1789     1789              
==========================================
- Hits        10978     8213    -2765     
+ Misses       2013      576    -1437     
  Partials      263      263              
Flag Coverage Δ
python 90.73% <100.00%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/index/__init__.py 96.73% <100.00%> (ø)
src/core/src/ffi/nodegraph.rs
src/core/src/index/mod.rs
src/core/src/ffi/signature.rs
src/core/src/ffi/mod.rs
src/core/src/encodings.rs
src/core/tests/minhash.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/search.rs
src/core/src/ffi/utils.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26ac4e...68c7edb. Read the comment docs.

@ctb ctb changed the title [WIP] minor improvements to Index tests [MRG] minor improvements to Index tests Mar 27, 2022
@ctb ctb mentioned this pull request Mar 27, 2022
12 tasks
Base automatically changed from cleanup/index to latest March 29, 2022 00:01
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/test_index.py Outdated Show resolved Hide resolved
tests/test_index.py Outdated Show resolved Hide resolved
ctb and others added 2 commits March 28, 2022 17:07
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
@ctb ctb merged commit a78361d into latest Mar 29, 2022
@ctb ctb deleted the cleanup/index_2 branch March 29, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants