Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonify plugin updates jtedits #3372

Draft
wants to merge 78 commits into
base: main
Choose a base branch
from
Draft

Sonify plugin updates jtedits #3372

wants to merge 78 commits into from

Conversation

james-trayford
Copy link

Description

This pull request develops the Sonification functionality further

  • flux_viewer.update_listener_wls now takes a sequence of bounds rather than a min and max, to allow for composite selections with appropriate @observe keyword for spectral subselection
  • Handle composite regions appropriately - this is now treated as a single patched-together spectrum over the wavelenth range, enabling more sound frequency resolution over disconnected spectral regions.
  • Update some of the Sonify plug-in hints etc in the .vue file.
  • Default Equal Loudness Normalisation to True
  • Default maximum audio frequency to 1000 Hz
  • hide sample rate options from users
  • continuum subtraction fix for sonification

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

javerbukh and others added 30 commits July 31, 2024 17:27
@javerbukh
Create audified cube and use with spectrum at spaxel tool
6049d9a
@javerbukh
Add Sonify Data plugin and connect to spectrum per spaxel tool
627a34f
@javerbukh
Fix errors
9e98b32
@javerbukh
Try moving code to mixin
e6d52b4
@javerbukh
Move code to viewers.py
0080b2f
@javerbukh
Remove print statements
4b01304
Patches:
505f73f 
- Fix sigcube alignment with other cubes [get rid of transpose]
- Add percentile cut option that enables some rough feature isolation without full continuum subtraction
- Protect against cubes w/NaNs
fix np import
89d6fff
add audio frequency range choice and equal loudness normalisation opt…
5c67736 
…ions
@javerbukh
Create dropdown to select output sound device
d8937c5
@javerbukh
Various updates and QOL improvements
75b7ded
@javerbukh
Connect volume level in viewer to sonify plugin
9d6844d
add volume attenuation functionality
1d1417c
add sound device switching
6421ee5
feed ELN flag to Image Viewer
352eff9
@javerbukh
Merge pull request spacetelescope#18 from james-trayford/sonify-plugi…
a7d501e 
…n-updates-jt

Sonify plugin updates jt
@javerbukh
Enable start stop stream and strauss soft dependency
ceafbb0
@javerbukh
Add note to plugin when strauss is not downloaded
a4811e4
@javerbukh
Add strauss as soft dependency
2a270ec
@javerbukh
Get build devices method working on windows
13f37a8
ensure sound generation always uses the current spectrum-at-spaxel wl…
4a1d628 
… range
post rebase clean-up (remove prints and rogue spaces)
a05937d
this syntax seems to work to install strauss on our specific git bran…
0f0eb87 
…ch for now, while awaitin PyPI release
@javerbukh
Merge pull request spacetelescope#19 from james-trayford/sonify-plugi…
a56b26e 
…n-updates-jt

Some more functionality tweaks
@javerbukh
Update code to be PEP8
18634ea
@javerbukh
PEP8 fixes
cc51183
@javerbukh
Merge branch 'main' into sonify-plugin-updates
5d308ea
@javerbukh
Remove old code
c6de013
@javerbukh
Fix test
eaae60f
@javerbukh
Fix test 2
9682321
pllim and others added 25 commits December 12, 2024 10:33
@pllim
not a Python package
8172cdd
@javerbukh
Catch case with no sound devices and set plugin to disabled
b552edc
catch no sound device case without errors in other cases, also remove…
30e8ad2 
… tqdm use and import, and use main branch strauss which should now work for JDAViz!
@javerbukh
Fix check for sound devices
4494ba5
i needed these quotes for the pip suggestion to work
92982bd
remove debug print
17fd0e5
revert change
dc478ce
@javerbukh
Merge pull request spacetelescope#23 from james-trayford/jt_listener_…
e25022f 
…mergechanges

Jt listener pre merge changes
@javerbukh
Fix codestyle and stop sonify plugin test running on CI
cc81d63
@javerbukh
Merge branch 'main' into sonify-plugin-updates
fdef225
@javerbukh
Add test that can run on CI
41b51f6
@javerbukh
add test to run with CI
a12b687
@javerbukh
Prevent running sonify cube method if disabled_msg is set
908e0af
@javerbukh
Use pytest for conditional
4f34615
@pllim
Update test_sonify_data.py
708024c
@javerbukh
Add change log entry
3081c4d
@javerbukh
Addres review comments
393031b
@javerbukh
Replace audif- with sonif-
853265a
@javerbukh
Change install instructions to pip install strauss
65afcbc
support composite specctral regions, and ensure spectral regions are …
280e72c 
…up-to-date n render
sonification plugin options: rearrange, label, defaults.
8b57148
git push cleanup
fec1d83
update max adio freq default
97bb60d
make some of the advanced options inaccessible, add some better funct…
ad443b6 
…ionality for flux %ile removal
take out tqdm loop
1c74635
@github-actions github-actions bot added documentation Explanation of code and concepts cubeviz testing imviz plugin Label for plugins common to multiple configurations labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim will be requested when the pull request is marked ready for review pllim is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cubeviz documentation Explanation of code and concepts imviz plugin Label for plugins common to multiple configurations testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-trayford @javerbukh @pllim