Fixed render issue where writeline inside status caused corrupt output #415 #694 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'd love to see this get merged in. Is there a way that I can help resolve any blockers that are standing in the way of doing so? |
|
@mscottford Absolutely. I'll take a look at it tomorrow. |
patriksvensson
approved these changes
Jun 4, 2023
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #415 #694
The problem was inside the method PositionCursor in LiveRenderable where the cursor (before the fix) just moved from to the bottom to the starting point without clearing the lines it passed through. This caused the statusmessage to still be visible when the writeline message was the first renderable to be rendered and its second/wrapped line (the line where the statusmessage still was present) was shorter than the statusmessage.
I've fixed it by clearing the lines it passes through when re-positioning the cursor for re-rendering.
Additional context, illustrations and issue description can be found in the referenced issues.