Merging v2.13 into v3.0-dev #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
msmakouz
commented
Apr 29, 2022
msmakouz
commented
| Q | A |
|---|---|
| Bugfix? | ❌ |
| Breaks BC? | ❌ |
| New feature? | ❌ |
Co-authored-by: Maxim Smakouz <m.smakouz@gmail.com>
Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
Update psr/log dependency version
Co-authored-by: roxblnfk <roxblnfk@ya.ru>
[ci skip] [skip ci]
…eature/broadcasting-2.0
- Fixes tests for LogBroadcast. - Gets rid of BroadcastConfig on AuthorizationMiddleware.
Adding chunkSize to the HTTP config
Improves broadcasting guard.
Adding Queueable attribute
Make dumper deprecated
…-master # Conflicts: # CHANGELOG.md # composer.json # monorepo-builder.php # src/AnnotatedRoutes/composer.json # src/Annotations/composer.json # src/Annotations/src/AnnotatedClass.php # src/Annotations/src/AnnotatedMethod.php # src/Annotations/src/AnnotatedProperty.php # src/Attributes/composer.json # src/Auth/composer.json # src/AuthHttp/composer.json # src/Boot/composer.json # src/Boot/src/AbstractKernel.php # src/Bridge/DataGrid/README.md # src/Bridge/DataGrid/composer.json # src/Bridge/DataGrid/src/Annotation/DataGrid.php # src/Bridge/DataGrid/src/Bootloader/GridBootloader.php # src/Bridge/DataGrid/src/Config/GridConfig.php # src/Bridge/DataGrid/src/GridInput.php # src/Bridge/DataGrid/src/Interceptor/GridInterceptor.php # src/Bridge/DataGrid/src/Response/GridResponse.php # src/Bridge/DataGrid/src/Response/GridResponseInterface.php # src/Bridge/Dotenv/composer.json # src/Bridge/Monolog/composer.json # src/Bridge/Stempler/composer.json # src/Cache/composer.json # src/Config/composer.json # src/Console/composer.json # src/Cookies/composer.json # src/Core/composer.json # src/Csrf/composer.json # src/DataGrid/composer.json # src/Debug/composer.json # src/Distribution/composer.json # src/Dumper/composer.json # src/Encrypter/composer.json # src/Exceptions/composer.json # src/Exceptions/src/HtmlHandler.php # src/Files/composer.json # src/Filters/composer.json # src/Framework/Bootloader/Broadcast/BroadcastBootloader.php # src/Framework/Bootloader/CommandBootloader.php # src/Framework/Bootloader/Http/HttpBootloader.php # src/Framework/Bootloader/Http/WebsocketsBootloader.php # src/Framework/Broadcast/Config/WebsocketsConfig.php # src/Framework/Broadcast/Middleware/WebsocketsMiddleware.php # src/Framework/Command/Database/ListCommand.php # src/Framework/Command/Database/TableCommand.php # src/Framework/Command/GRPC/GenerateCommand.php # src/Framework/Command/GRPC/ListCommand.php # src/Framework/Command/Migrate/AbstractCommand.php # src/Framework/Command/Migrate/InitCommand.php # src/Framework/Command/Migrate/MigrateCommand.php # src/Framework/Command/Migrate/ReplayCommand.php # src/Framework/Command/Migrate/RollbackCommand.php # src/Framework/Command/Migrate/StatusCommand.php # src/Framework/GRPC/Exception/CompileException.php # src/Framework/GRPC/GRPCDispatcher.php # src/Framework/GRPC/LocatorInterface.php # src/Framework/GRPC/ProtoCompiler.php # src/Framework/GRPC/ServiceLocator.php # src/Framework/Http/LegacyRrDispatcher.php # src/Framework/Http/RrDispatcher.php # src/Framework/Http/SapiDispatcher.php # src/Hmvc/composer.json # src/Http/composer.json # src/Http/src/Emitter/SapiEmitter.php # src/Http/src/EmitterInterface.php # src/Http/src/Exception/EmitterException.php # src/Http/src/SapiRequestFactory.php # src/Logger/composer.json # src/Mailer/composer.json # src/Models/composer.json # src/Pagination/composer.json # src/Prototype/composer.json # src/Prototype/src/Bootloader/PrototypeBootloader.php # src/Queue/composer.json # src/Reactor/composer.json # src/Router/composer.json # src/Scaffolder/composer.json # src/Security/composer.json # src/SendIt/composer.json # src/Session/composer.json # src/Snapshots/composer.json # src/Stempler/composer.json # src/Storage/composer.json # src/Streams/composer.json # src/Tokenizer/composer.json # src/Translator/composer.json # src/Validation/composer.json # src/Views/composer.json
Codecov Report
@@ Coverage Diff @@
## 3.0 #677 +/- ##
============================================
+ Coverage 82.03% 82.06% +0.02%
- Complexity 5426 5492 +66
============================================
Files 611 623 +12
Lines 13608 13755 +147
============================================
+ Hits 11164 11288 +124
- Misses 2444 2467 +23
Continue to review full report at Codecov.
|
roxblnfk
approved these changes
May 1, 2022
roxblnfk
reviewed
May 1, 2022
Comment on lines
+11
to
+26
| private bool $success; | ||
| private array $topics; | ||
| private array $attributes; | ||
| private ?ResponseInterface $response; | ||
|
|
||
| public function __construct( | ||
| bool $success, | ||
| array $topics, | ||
| array $attributes = [], | ||
| ?ResponseInterface $response = null | ||
| ) { | ||
| $this->success = $success; | ||
| $this->topics = $topics; | ||
| $this->attributes = $attributes; | ||
| $this->response = $response; | ||
| } |
There was a problem hiding this comment.
Can be replaced with promouted properties;
Also getters can be replaced with public readonly properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.