Ensure correct MapNumber logic when restoring from backups with draws + add series clinch config parameter + fix OnSeriesResult #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdnk
commented
Aug 7, 2022
nickdnk
commented
Aug 8, 2022
nickdnk
force-pushed
the
fix_backups_with_draws
branch
3 times, most recently
from
2783c75 to
d4109ba
Compare
nickdnk
changed the title
|
Last commit fixes #728 |
nickdnk
force-pushed
the
fix_backups_with_draws
branch
from
1889fe4 to
4cf2222
Compare
|
Tested everything in here and it seems to work as expected. Tested |
nickdnk
commented
Aug 9, 2022
nickdnk
force-pushed
the
fix_backups_with_draws
branch
from
4cf2222 to
225b2a6
Compare
nickdnk
changed the title
nickdnk
force-pushed
the
fix_backups_with_draws
branch
from
225b2a6 to
5d7244d
Compare
|
Now also fixes #213 |
nickdnk
changed the title
nickdnk
changed the title
nickdnk
commented
Aug 11, 2022
nickdnk
force-pushed
the
fix_backups_with_draws
branch
from
b046f02 to
9c8d3ca
Compare
|
Fixes #190 now also. |
Closed
nickdnk
force-pushed
the
fix_backups_with_draws
branch
2 times, most recently
from
adacb56 to
10819c6
Compare
nickdnk
force-pushed
the
fix_backups_with_draws
branch
2 times, most recently
from
8f892d8 to
88d162d
Compare
|
I changed the translation logic to always inject the color around variables if applicable. This means we don't have to make sure different languages use the same colors. I also cleaned up some of the translations a bit, where I could. Player names are now colored based on the side they are on, so for instance when Commands in translations (.ie. |
…draws Read round number from valve backup on restore event Use g_MapNumber in more places and reduce use of Get5_GetMapNumber where not needed Properly calculate series results when ties are included Remove bo2 tie message (it was used when not bo2) Remove call to WriteBackup on match end Remove unused translation from docs
nickdnk
force-pushed
the
fix_backups_with_draws
branch
2 times, most recently
from
0718f2c to
66743d7
Compare
Cleaned up EndSeries call Fixed match restart delay to GOTV delay Remove unnecessary g_ForceWinnerSignal and g_ForcedWinner vars Remove duplicate call to Stats_SeriesEnd when forfeiting Ensure Get5_OnDemoFinished is detached from global vars and on a delay for file flush Adjust translation to include time-to-map-change Ensure SetMatchRestartDelay is called after cvars are set, using timers Use datapacks for all backup timer chains, ensuring nothing messes with the parameters Update translations doc + danish Fix mp_match_restart_delay problems related to restoring cvars Cleaned up duplicate code used to start recording, moved all code to recording.sp prevent invalid handle if RestoreCvars is called twice Always reset g_DemoFileName on map start
nickdnk
force-pushed
the
fix_backups_with_draws
branch
2 times, most recently
from
68784d9 to
ff2e6e8
Compare
Don't wait for gotv when restoring cvars when force-ending a match ensure endmatch unpauses the game
Add gold color; color player names based on their current side Fixed some translations consistently color team names
Fixed correct callout and graphics for winning team when knife-round ends Get rid of Timer_PostKnife Always reset g_HasKnifeRoundStarted when loading configs or maps
nickdnk
force-pushed
the
fix_backups_with_draws
branch
from
ff2e6e8 to
d9b4a16
Compare
splewis
reviewed
Aug 13, 2022
splewis
reviewed
Aug 13, 2022
splewis
reviewed
Aug 13, 2022
splewis
approved these changes
Aug 13, 2022
Merged
This was referenced Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #817.
I also adjusted
Get5_OnBackupRestoreto have the correct map and round number, indicating the match, map and round being restored to.Tried to reduce use of
Get5_GetMapNumber()where it is not needed.Fixed problems with ties not correctly affecting the next map/series end logic.
I put the fix for #822 in here as well.
Added a
g_SeriesCanClinchoption that allows you to disable clinch-logic in a series, similarly tomp_match_can_clinch, but for maps.I've moved a lot of code around, fixing the delay on
OnSeriesResultand probably fixing a lot of weird issues with GOTV recordings.mp_match_restart_delayis now corrected if it is not long enough, but not shortened if longer. This allows admins to set a longer, fixed pause length between maps regardless of the length of the GOTV delay. Essentially this now includes #825, but I had to put that on top of this due to the way map scores are now handled. This also gets rid ofg_ForceWinnerSignalandg_ForcedWinner.Everything here is tested and it all works as far as I can tell.