Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of problems with GOTV delays #839

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix a bunch of problems with GOTV delays #839

merged 1 commit into from
Aug 15, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Aug 14, 2022

So it turns out that the GOTV-related stuff I made in #821 caused some problems, as I had slightly misunderstood how the GOTV delay affected recording of demos. This PR fixes all that, and I've tested it a lot.

I've taken tv_delay parameters out of the sample config files and discouraged people from putting tv_ in their warmup/live, as changing the delay while changing game states messes with the demos. I took out tv_delaymapchange as well, as Get5 automatically makes this adjustment when a map ends. tv_-commands should be added to the server permanently (by some other config) or set in the match config cvar section, so they don't vary between stages.

Added a separate section on GOTV to the docs also.

This also fixes some race-condition related stuff in the Get5_OnDemoFinished event if quickly ending/starting matches, using DataPacks

@nickdnk nickdnk merged commit 8011efd into development Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant