Fix a bunch of problems with GOTV delays #839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that the GOTV-related stuff I made in #821 caused some problems, as I had slightly misunderstood how the GOTV delay affected recording of demos. This PR fixes all that, and I've tested it a lot.
I've taken
tv_delay
parameters out of the sample config files and discouraged people from puttingtv_
in their warmup/live, as changing the delay while changing game states messes with the demos. I took outtv_delaymapchange
as well, as Get5 automatically makes this adjustment when a map ends.tv_
-commands should be added to the server permanently (by some other config) or set in the match configcvar
section, so they don't vary between stages.Added a separate section on GOTV to the docs also.
This also fixes some race-condition related stuff in the
Get5_OnDemoFinished
event if quickly ending/starting matches, usingDataPack
s