Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GOTV and cvar restore logic #841

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Adjust GOTV and cvar restore logic #841

merged 1 commit into from
Aug 15, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Aug 15, 2022

So it turns out that the GOTV-related stuff I made in #821 caused some problems, as I had slightly misunderstood how the GOTV delay affected recording of demos. This PR fixes all that, and I've tested it a lot.

I've taken tv_delay parameters out of the sample config files and discouraged people from putting tv_ in their warmup/live, as changing the delay while changing game states messes with the demos. I took out tv_delaymapchange as well, as Get5 automatically makes this adjustment when a map ends. tv_-commands should be added to the server permanently (by some other config) or set in the match config cvar section, so they don't vary between stages.

Added a separate section on GOTV to the docs also.

This also fixes some race-condition related stuff in the Get5_OnDemoFinished event if quickly ending/starting matches, using DataPacks

Accidentally pushed to develop, which was reset; replacement for #839

@nickdnk nickdnk added the bug label Aug 15, 2022
@nickdnk nickdnk added this to the 0.10 milestone Aug 15, 2022
@nickdnk nickdnk self-assigned this Aug 15, 2022
@nickdnk nickdnk merged commit 734e485 into development Aug 15, 2022
@nickdnk nickdnk deleted the fix_gotv branch August 15, 2022 00:28
@deLuXe83
Copy link

Hi,
I am now on Plugin version: 0.10.0-972ce8f. Runs smooth!

What I experience is that between mapchange there is a 2 Minute wait-time. tv_delay is set to 15 sec.

@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 20, 2022

@deLuXe83 Hello

What is your mp_match_restart_delay? It will only be increased if not long enough to let GOTV finish; it will not be reduced if larger as of this version.

Edit: The idea behind this is that you could now set a fixed 5 or 10 minute break between maps in a tournament environment.

nickdnk added a commit that referenced this pull request Aug 20, 2022
@deLuXe83
Copy link

deLuXe83 commented Aug 22, 2022

@deLuXe83 Hello

What is your mp_match_restart_delay? It will only be increased if not long enough to let GOTV finish; it will not be reduced if larger as of this version.

'mp_match_restart_delay' was not set at all.

I will give it a try next text, because I really like this:

Edit: The idea behind this is that you could now set a fixed 5 or 10 minute break between maps in a tournament environment.

idea!!

@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 22, 2022

You are setting it somewhere, because the default value is 15 seconds.

@deLuXe83
Copy link

.... not on porpuse :)

I added it now to my 'warmup.cfg' and will monitor it next time.

@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 22, 2022

Alright, but semantically it belongs in the live.cfg, as this never applies to the warmup period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants