Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how validating 1.0.0-rc.1 extensions are handled #333

Closed
jonhealy1 opened this issue May 5, 2021 · 0 comments · Fixed by #455
Closed

Change how validating 1.0.0-rc.1 extensions are handled #333

jonhealy1 opened this issue May 5, 2021 · 0 comments · Fixed by #455
Milestone
1.0.0-rc.1

Comments

@jonhealy1
Copy link
Contributor

In validate_dict there is this check:
# If the version is before 1.0.0-rc.1, substitute extension short IDs for their schemas.
if stac_version_id < "1.0.0-rc.1":

Should this not be 'if stac_version_id < "1.0.0-rc.2":' ?

In the 1.0.0-rc.1 examples I downloaded from Radiant Earth, stac extensions are still using the shortened identifiers like 'eo' or 'projection'.
@jonhealy1 jonhealy1 changed the title Change how 1.0.0-rc.1 extensions are handled Change how validating 1.0.0-rc.1 extensions are handled May 5, 2021
@jonhealy1 jonhealy1 mentioned this issue May 8, 2021
Closed
4 tasks
@duckontheweb duckontheweb modified the milestones: 1.0.0-rc.1, 1.0.0 Jun 4, 2021
duckontheweb pushed a commit to duckontheweb/pystac that referenced this issue Jun 18, 2021
@jonhealy1 @duckontheweb
Fix stac-utils#333 and fix stac-utils#334
3ee225a
@duckontheweb duckontheweb mentioned this issue Jun 18, 2021
Merged
5 tasks
@duckontheweb duckontheweb linked a pull request Jun 18, 2021 that will close this issue
Fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #455
Merged
5 tasks
@duckontheweb duckontheweb modified the milestones: 1.0.0, 1.0.0-rc.1 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc.1
2 participants
@duckontheweb @jonhealy1