Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #455

Merged
merged 4 commits into from
Jun 18, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 18, 2021

Related Issue(s):

Description:

Builds off of #336 by fixing an issue with examples-info.csv, rebasing, and squashing commites. Thanks @jonhealy1!

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #455 (7b3acf9) into main (6937607) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          40       40           
  Lines        5240     5240           
=======================================
  Hits         4794     4794           
  Misses        446      446           
Impacted Files Coverage Δ
pystac/validation/schema_uri_map.py 86.84% <ø> (ø)
pystac/validation/__init__.py 84.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6937607...7b3acf9. Read the comment docs.

Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should drop the empty README at tests/data-files/examples/1.0.0-RC1/README.md

Otherwise GTG

@duckontheweb duckontheweb merged commit 73a9126 into stac-utils:main Jun 18, 2021
@duckontheweb duckontheweb deleted the issues_333_334 branch June 18, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide validation support for 1.0.0-beta.1 Change how validating 1.0.0-rc.1 extensions are handled
4 participants