Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #336

jonhealy1 · 2021-05-08T00:12:32Z

Resolves: #333
Resolves: #334

Related Issue(s): #333 #334

Description:
This fixes how version 1.0.0-rc.1 extensions are handled because they are still using the shortened identifiers. It also fixes the schemas for 1.0.0-beta.1 because these are not on schemas.stacspec.org.

PR Checklist:

Code is formatted (run scripts/format)
Tests pass (run scripts/test) - I need a password for this?
This PR maintains or improves overall codebase code coverage.
Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

lossyrob · 2021-05-18T16:22:59Z

Hey @jonhealy1, seems like there's a lot of commits here but the final line changes are +12/-8 ... did some things get lost in the shuffle or are some of these changes reverted?

jonhealy1 · 2021-05-18T16:49:15Z

Hi @lossyrob sorry yes. I was implementing tests to run validation against some of the stac objects we test against for stac-validator. I pulled those changes out and pushed them to a local branch because they are not finished and I wasn't sure if it was something that would be valuable.

jonhealy1 · 2021-05-18T16:51:08Z

There are only a few minor changes in this pr.

lossyrob · 2021-05-18T16:54:04Z

Ok, gotcha. I'll do a squash commit on this PR so that we can get rid of those extraneous commits in the main history. GitHub Actions seems to be having some issues so we'll wait until we can rerun the CI, but this is looking good to me

jonhealy1 · 2021-05-18T17:19:39Z

Thank you. Next time I will be more careful.

jonhealy1 · 2021-05-18T17:31:10Z

@lossyrob I could redo the pr too if it's easier.

lossyrob · 2021-05-18T18:04:17Z

Nah a squash commit will do the trick. If you wanted to you could rebase these commits into one or two and force push to your branch, which would clean this PR up, but I wouldn't worry about it too much!

lossyrob · 2021-05-23T17:22:16Z

@jonhealy1 I think it would make sense to add a test case for an .rc1 STAC item that would fail without this change, so we can guard against changes that might break this in the future.

jonhealy1 · 2021-05-30T17:35:03Z

@lossyrob Just for reference - name shortcuts became invalid in 1.0.0-rc.2 not 1.0.0-rc.1

https://github.com/radiantearth/stac-spec/blob/master/CHANGELOG.md#removed-1

v1.0.0-rc.2 - 2021-03-30
Changed
Required properties of type string require a minimum length of 1. (#1065)
gsd must be greater than 0. (#1068)
Removed
The remaining extensions in the spec (EO, Projection, Scientific Citation and View) have been moved out of the core specification, into their own repos in the stac-extensions GitHub organization. They must now be referred to by their schemas directly - the name shortcuts for them are no longer valid. The concept of the 'named shortcut' also goes away entirely. (#1070)

jonhealy1 · 2021-05-30T18:39:34Z

@lossyrob test_identify.py fails because of the 1.0.0-rc.1 example I added to example-info.csv for testing?

E AssertionError: False is not true : Failed /Users/comp/Sparkgeo/pystac/tests/data-files/examples/1.0.0-RC1/extended-item.json:

tests/serialization/test_identify.py:45: AssertionError

jonhealy1 · 2021-05-30T18:53:11Z

nevermind - someone put the 1.0.0-beta.2 examples in the 1.0.0-RC1 folder

jonhealy1 · 2021-05-30T19:18:18Z

E fixture 'test_class' not found

======================================= short test summary info ========================================
ERROR tests/test_item.py::test_to_from_dict
ERROR tests/extensions/test_eo.py::test_to_from_dict
ERROR tests/extensions/test_file.py::test_to_from_dict
ERROR tests/extensions/test_label.py::test_to_from_dict
ERROR tests/extensions/test_pointcloud.py::test_to_from_dict
ERROR tests/extensions/test_projection.py::test_to_from_dict
ERROR tests/extensions/test_timestamps.py::test_to_from

duckontheweb · 2021-06-03T18:53:29Z

tests/data-files/examples/example-info.csv

+"1.0.0-RC3/catalog.json","CATALOG","1.0.0-rc.3",""
+"1.0.0-RC3/collection-only/collection.json","COLLECTION","1.0.0-rc.3","https://stac-extensions.github.io/eo/v1.0.0/schema.json|https://stac-extensions.github.io/projection/v1.0.0/schema.json|https://stac-extensions.github.io/view/v1.0.0/schema.json"
+"1.0.0-RC3/collection.json","COLLECTION","1.0.0-rc.3","https://stac-extensions.github.io/eo/v1.0.0/schema.json|https://stac-extensions.github.io/view/v1.0.0/schema.json"
+"1.0.0-RC3/collectionless-item.json","ITEM","1.0.0-rc.3","https://stac-extensions.github.io/eo/v1.0.0/schema.json|https://stac-extensions.github.io/view/v1.0.0/schema.json"
+"1.0.0-RC3/core-item.json","ITEM","1.0.0-rc.3",""
+"1.0.0-RC3/extended-item.json","ITEM","1.0.0-rc.3","https://stac-extensions.github.io/eo/v1.0.0/schema.json|https://stac-extensions.github.io/projection/v1.0.0/schema.json|https://stac-extensions.github.io/scientific/v1.0.0/schema.json|https://stac-extensions.github.io/view/v1.0.0/schema.json|https://stac-extensions.github.io/remote-data/v1.0.0/schema.json"
+"1.0.0-RC3/extensions-collection/collection.json","COLLECTION","1.0.0-rc.3",""
+"1.0.0-RC3/extensions-collection/proj-example/proj-example.json","ITEM","1.0.0-rc.3","https://stac-extensions.github.io/eo/v1.0.0/schema.json|https://stac-extensions.github.io/projection/v1.0.0/schema.json"


Looks like these files don't exist yet, but once that's fixed this looks good to me, too.

Actually, I think these just need to be changed to 1.0.0-RC2. @jonhealy1 I'm happy to merge in main and update this if you want. I think this PR is ready to go other than this.

I think I only added in one rc1 and one rc2 entry. I think the rc3 stuff comes from a previous iteration of what I was building off of? If you can get it working to merge that would be great. Cheers.

Ah, yeah, I see that now. I'll try to work through that and get the tests working again.

duckontheweb · 2021-06-18T01:10:19Z

@jonhealy1 @lossyrob I didn't have write permissions to this branch, so I opened up a separate PR (#455).

jonhealy1 added 11 commits May 7, 2021 09:49

add .vscode to .gitignore

9ff0802

fix version check where 1rc1 extensions were not working

a9371e7

add staclint.com for 1beta1, add stac-validator test files

b8388b7

fix broken 1beta1 validation

194029a

create tests for older versions

d8d38e0

create tests for older versions 2

8d66756

create tests for older versions 3

e681817

change 1beta1 schema address

382e9f4

new validation tests passing

3033239

fix 1rc1 extensions and 1beta1 schemas

a345f05

format

d4cd701

jonhealy1 changed the title ~~Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schemas~~ Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links May 8, 2021

duckontheweb added the PySTAC 1.0 label May 18, 2021

add 1.0.0-rc.1 and 1.0.0-rc.2 examples to example-info.csv for testing

b3fc65e

remove 1beta2 files from 1RC1 folder and put right files in

4539e8c

jonhealy1 added 2 commits May 30, 2021 13:15

add extensions to 1rc1 and 1rc2 examples file

b019196

Merge branch 'main' into issues_333_334

73c2d00

duckontheweb reviewed Jun 3, 2021

View reviewed changes

duckontheweb modified the milestones: 1.0.0-rc.1, 1.0.0 Jun 4, 2021

duckontheweb modified the milestones: 1.0.0, 1.0.0-rc.1 Jun 17, 2021

duckontheweb mentioned this pull request Jun 18, 2021

Fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #455

Merged

5 tasks

duckontheweb closed this Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #336

Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #336

jonhealy1 commented May 8, 2021 •

edited

Loading

lossyrob commented May 18, 2021

jonhealy1 commented May 18, 2021

jonhealy1 commented May 18, 2021

lossyrob commented May 18, 2021

jonhealy1 commented May 18, 2021

jonhealy1 commented May 18, 2021

lossyrob commented May 18, 2021

lossyrob commented May 23, 2021

jonhealy1 commented May 30, 2021 •

edited

Loading

jonhealy1 commented May 30, 2021

jonhealy1 commented May 30, 2021

jonhealy1 commented May 30, 2021 •

edited

Loading

duckontheweb Jun 3, 2021

duckontheweb Jun 16, 2021

jonhealy1 Jun 16, 2021

duckontheweb Jun 16, 2021

duckontheweb commented Jun 18, 2021

Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #336

Issues 333 334 - fix 1.0.0-rc.1 extensions and 1.0.0-beta.1 schema links #336

Conversation

jonhealy1 commented May 8, 2021 • edited Loading

lossyrob commented May 18, 2021

jonhealy1 commented May 18, 2021

jonhealy1 commented May 18, 2021

lossyrob commented May 18, 2021

jonhealy1 commented May 18, 2021

jonhealy1 commented May 18, 2021

lossyrob commented May 18, 2021

lossyrob commented May 23, 2021

jonhealy1 commented May 30, 2021 • edited Loading

jonhealy1 commented May 30, 2021

jonhealy1 commented May 30, 2021

jonhealy1 commented May 30, 2021 • edited Loading

duckontheweb Jun 3, 2021

Choose a reason for hiding this comment

duckontheweb Jun 16, 2021

Choose a reason for hiding this comment

jonhealy1 Jun 16, 2021

Choose a reason for hiding this comment

duckontheweb Jun 16, 2021

Choose a reason for hiding this comment

duckontheweb commented Jun 18, 2021

jonhealy1 commented May 8, 2021 •

edited

Loading

jonhealy1 commented May 30, 2021 •

edited

Loading

jonhealy1 commented May 30, 2021 •

edited

Loading