Transition to the fdcan-rs crate #39
Conversation
|
@luctius is there anything I can do to help get this in? I have a board with an STM32g4 and 2 CAN transceivers on it that I can do testing on if needed. At the moment I am using a super hacky driver in my own code to get the CAN working but I would love to move to this if possible. |
luctius
force-pushed
the
features/fdcan-rs
branch
2 times, most recently
from
fe728d8
to
452437f
Compare
|
I've updated this to fdcan 0.1.2. It builds; but if you have time I would mind if you could check that everything still works. |
There was a problem hiding this comment.
I made some changes to the example itself to get this going on my hardware and I was able to get the the two channels on my board to talk to each other. Functionally, I think this is good to go in.
I can put up a follow-on PR that cleans up the example to allow running it either on physical hardware or in loopback mode for testing. I should be able to get that up in a day or two.
Cargo.toml
Outdated
| @@ -23,6 +23,14 @@ static_assertions = "1.1" | |||
| version = "0.7.7" | |||
| features = ["critical-section-single-core"] | |||
|
|
|||
| [dependencies.fdcan] | |||
| # git = "https://github.com/stm32-rs/fdcan.git" | |||
There was a problem hiding this comment.
Probably don't want to merge with these commented bits in here.
src/lib.rs
Outdated
| // pub mod can; | ||
| pub mod fdcan; | ||
| pub mod can; | ||
| // pub mod fdcan; |
luctius
force-pushed
the
features/fdcan-rs
branch
from
452437f
to
b5f5fa9
Compare
As discussed in #34, the FDCAN part has been transitioned to a new crate. This PR uses that crate instead of our own implementation.