Unlink as coverage #1847
Unlink as coverage #1847
Conversation
|
can you fix CI before assigning for review? :) image |
|
Update package-json to use cc develop |
|
which ticket is this handling? |
SDESK-7017 |
| onTrigger: () => { | ||
| const superdeskArticle = superdesk.entities.article; | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Did you take these conditions from somewhere else? In order not to duplicate it, we should add canUnlinkAscoverage function and expose it via extensions bridge.
There was a problem hiding this comment.
The thing is, we can't add it 1-to-1, because in the angular world permissions work under the hood, so if we do add it it'll still be chopped up. Personally I don't think it's necessary when this is the case, so we can keep it like this
There was a problem hiding this comment.
add the comment about keeping it up to date
| onTrigger: () => { | ||
| const superdeskArticle = superdesk.entities.article; | ||
|
|
||
| if ( |
There was a problem hiding this comment.
add the comment about keeping it up to date
|
one more thing, add |
|
did you see my last comment? |
| @@ -103,6 +103,8 @@ function configurePlanning(superdesk) { | |||
| !['killed', 'recalled', 'unpublished', 'spiked', 'correction'].includes(item.state); | |||
| }], | |||
| }) | |||
|
|
|||
| // TAG: AUTHORING-ANGULAR | |||
There was a problem hiding this comment.
I'm wondering about that external-app action.
It looks like the same action also appears in the topbar. Could you double check whether we also have it in authoring-react?
There was a problem hiding this comment.
@thecalcc have you looked into this yet?
There was a problem hiding this comment.
I'm doing so yep, but I plan to address it in a different PR. haven't forgotten about it
There was a problem hiding this comment.
I'm doing so yep, but I plan to address it in a different PR. haven't forgotten about it
In short, looks like this is some filtering based on which we calculate whether to show the action in the three dots menu or not
SDESK-7017