-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fulfil assignment #1848
base: develop
Are you sure you want to change the base?
Fulfil assignment #1848
Conversation
@@ -13,6 +13,9 @@ import {AssignmentsList} from './assignments-overview'; | |||
import {IPlanningExtensionConfigurationOptions} from './extension_configuration_options'; | |||
import {AutopostIngestRuleEditor} from './ingest_rule_autopost/AutopostIngestRuleEditor'; | |||
import {AutopostIngestRulePreview} from './ingest_rule_autopost/AutopostIngestRulePreview'; | |||
import ng from 'superdesk-core/scripts/core/services/ng'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extensions must not import anything neither from core nor planning. Instead either use superdesk api or planning api via bridge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix CI
Update package-json to use cc develop |
Address last comment from #1847 |
} | ||
}, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether this would appear in authoring-angular as well?
No description provided.