Skip to content

Commit

Permalink
[AutoDiff] Delete wrong FIXMEs (TF-284) from tests (#78663)
Browse files Browse the repository at this point in the history
In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a
couple of following FIXMEs:

```
// FIXME(TF-284): Fix unexpected diagnostic.
```

However, the diagnostic is expected for the case of public protocol
requirements: see description #30629.
This PR removed the diagnostic for less-than-public-visible requirements,
and the FIXME was initially related to them.

It looks like that the FIXMEs present now are a result of copy-paste and
have no meaning, and the diagnostic is expected and should be present and
does not need to be removed.

Fixes #78609
  • Loading branch information
kovdan01 authored Jan 16, 2025
1 parent 6576929 commit ccdce9f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/AutoDiff/Sema/differentiable_attr_type_checking.swift
Original file line number Diff line number Diff line change
Expand Up @@ -290,15 +290,13 @@ public struct PublicDiffAttrConformance: ProtocolRequirements {
var x: Float
var y: Float

// FIXME(TF-284): Fix unexpected diagnostic.
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Float)'}}
public init(x: Float, y: Float) {
self.x = x
self.y = y
}

// FIXME(TF-284): Fix unexpected diagnostic.
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Int)'}}
public init(x: Float, y: Int) {
Expand Down

0 comments on commit ccdce9f

Please sign in to comment.