[AutoDiff] Delete wrong FIXMEs (TF-284) from tests #78663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a couple of following FIXMEs: ``` // FIXME(TF-284): Fix unexpected diagnostic. ``` However, the diagnostic is expected for the case of public protocol requirements: see description swiftlang#30629. This PR removed the diagnostic for less-than-public-visible requirements, and the FIXME was initially related to them. It looks like that the FIXMEs present now are a result of copy-paste and have no meaning, and the diagnostic is expected and should be present and does not need to be removed. Fixes swiftlang#78609
|
Tagging @asl @JaapWijnen @rxwei |
|
@swift-ci please smoke test |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a couple of following FIXMEs:
However, the diagnostic is expected for the case of public protocol requirements: see description #30629. This PR removed the diagnostic for less-than-public-visible requirements, and the FIXME was initially related to them.
It looks like that the FIXMEs present now are a result of copy-paste and have no meaning, and the diagnostic is expected and should be present and does not need to be removed.
Fixes #78609