Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note: FIXME(TF-284): Fix unexpected diagnostic. #78609

Closed
Tracked by #77773
asl opened this issue Jan 13, 2025 · 1 comment · Fixed by #78663
Closed
Tracked by #77773

Note: FIXME(TF-284): Fix unexpected diagnostic. #78609

asl opened this issue Jan 13, 2025 · 1 comment · Fixed by #78663
Labels
AutoDiff

Comments

@asl
Copy link
Contributor

asl commented Jan 13, 2025 •
edited
Loading

Test: AutoDiff/Sema/differentiable_attr_type_checking.swift
@asl asl mentioned this issue Jan 13, 2025
Open
20 tasks
@asl
Copy link
Contributor Author

asl commented Jan 13, 2025

Tagging @kovdan01

@asl asl added the AutoDiff label Jan 13, 2025
kovdan01 added a commit to kovdan01/swift that referenced this issue Jan 15, 2025
@kovdan01
[AutoDiff] Delete wrong FIXMEs (TF-284) from tests
574da8a 
In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a
couple of following FIXMEs:

```
// FIXME(TF-284): Fix unexpected diagnostic.
```

However, the diagnostic is expected for the case of public protocol
requirements: see description swiftlang#30629.
This PR removed the diagnostic for less-than-public-visible requirements,
and the FIXME was initially related to them.

It looks like that the FIXMEs present now are a result of copy-paste and
have no meaning, and the diagnostic is expected and should be present and
does not need to be removed.

Fixes swiftlang#78609
@kovdan01 kovdan01 mentioned this issue Jan 15, 2025
Merged
@asl asl closed this as completed in ccdce9f Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AutoDiff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AutoDiff] Delete wrong FIXMEs (TF-284) from tests kovdan01/swift
1 participant
@asl