Refactor @media handling
#14765
Merged
Refactor @media handling
#14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of re-parsing the `@media`, we parse it once and handle each param individually.
We do this for handling all other parts as well. This makes it more consistent.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on |
thecrypticace
approved these changes
Oct 23, 2024
This was referenced Oct 23, 2024
Merged
Closed
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an internal refactor to improve the way we handle at-rules. Essentially we check for the
@symbol and bail early if that's not the case.We also improve the way
@mediais being handled by first checking for@media, and then handle all the params separately.Last but not least, we also inverted the
@themecheck condition such that it is handled the same way we handle everything else.