-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new source(…)
#14767
Closed
Closed
Handle new source(…)
#14767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on Graphite |
Merged
RobinMalfait
force-pushed
the
robin/hide_skipped_tests
branch
from
October 23, 2024 18:27
614cb89
to
5700c5d
Compare
RobinMalfait
force-pushed
the
robin/handle_source_
branch
from
October 23, 2024 18:27
b77829b
to
19a83d6
Compare
RobinMalfait
force-pushed
the
robin/handle_source_
branch
4 times, most recently
from
October 25, 2024 11:16
45edace
to
a87e28c
Compare
RobinMalfait
force-pushed
the
robin/handle_source_
branch
from
October 25, 2024 15:22
47be35a
to
bcfd910
Compare
thecrypticace
force-pushed
the
robin/handle_source_
branch
from
October 28, 2024 21:20
39fa328
to
c51b20f
Compare
RobinMalfait
force-pushed
the
robin/handle_source_
branch
from
October 28, 2024 22:10
c51b20f
to
39fa328
Compare
Forward it from `@media source(…)` to `@tailwind utilities source(…)`. Next, handle `@tailwind utilities source(…)` and retrieve the path.
This integration test itself might change over time as we work through this PR.
We used to list `core` instead of `oxide`, this should make sure that building Oxide works if we make changes in `oxide/`.
Now that we can promote `@source "../path/to/folder"` to enable auto source detection, it means that we can just merge the globs together and add the base folder as if it was `@source "../path/to/folder"`
Ensure symlinks are handled because `/var/` points to `/private/var/`.
This now makes use of just `sources` instead of auto content detection.
Co-authored-by: Jordan Pittman <jordan@cryptica.me>
Co-authored-by: Jordan Pittman <jordan@cryptica.me>
Co-authored-by: Jordan Pittman <jordan@cryptica.me>
RobinMalfait
force-pushed
the
robin/handle_source_
branch
from
October 28, 2024 22:21
39fa328
to
d5b724c
Compare
This was referenced Oct 28, 2024
closed in favor of #14820 |
thecrypticace
added a commit
to tailwindlabs/tailwindcss-intellisense
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
source(…)
argument and improves on the existing@source
. The goal of this PR is to make the automatic source detection configurable, let's dig in.By default, we will perform automatic source detection starting at the current working directory. Auto source detection will find plain text files (no binaries, images, ...) and will ignore git-ignored files.
If you want to start from a different directory, you can use the new
source(…)
next to the@import "tailwindcss/utilities" layer(utilities) source(…)
.E.g.:
Most people won't split their source files, and will just use the simple
@import "tailwindcss";
, because of this reason, you can usesource(…)
on the import as well:E.g.:
Sometimes, you want to rely on auto source detection, but also want to look in another directory for source files. In this case, yuo can use the
@source
directive:However, you don't need to specify the extension, instead you can just point the directory and all the same automatic source detection rules will apply.
If, for whatever reason, you want to disable the default source detection feature entirely, and only want to rely on very specific glob patterns you define, then you can disable it via
source(none)
.Note: even with
source(none)
, if your@source
points to a directory, then auto source detection will still be performed in that directory. If you don't want that, then you can simply add explicit files in the globs as seen in the previous example.