Hide skipped tests #14766
Merged
Hide skipped tests #14766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on |
This was referenced Oct 23, 2024
Closed
thecrypticace
approved these changes
Oct 23, 2024
|
This one makes me happy 🥳 |
|
Does this one actually need to be part of the |
When you have a lot of tests, and use a `.only` on a specific test, then
all other tests are still visible in the UI. If you are logging
something, then you always have to scroll up.
To prevent this, we can use this flag to always hide the list of
skipped tests.
Note: the UI itself still has an indication that _something_ is being
skipped:
```console
Test Files 1 passed (1)
Tests 1 passed | 97 skipped (98)
Start at 13:27:14
Duration 55ms
```
RobinMalfait
force-pushed
the
robin/hide_skipped_tests
branch
from
614cb89 to
5700c5d
Compare
|
@adamwathan can definitely be a separate PR that doesn't need to be part of the stack. In fact, we can just merge this one. Reason it is part of the stack is because I changed this code while working on #14767, but didn't want to include it in that PR so created a separate branch from it. |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small quality of life improvement, but let's hide skipped tests. The summary still shows that there are skipped tests, but this makes the UI much better. Especially when debugging a single test, then you don't need to scroll up all the time.