-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove additional projectPortalConfig node – put everything global on site: siteMetadata #638
refactor: remove additional projectPortalConfig node – put everything global on site: siteMetadata #638
Conversation
✅ Deploy Preview for gatsby-theme-project-portal-ex-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gatsby-theme-project-portal-defaults ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for project-portal-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit f9d7678.
Note: This comment gets updated with every commit 77db4b818ceaf100080e4be1a0209a0676dd1c07 example-site |
…ve-project-portal-config-node-replace-sitemetadata # Conflicts: # packages/gatsby-theme-project-portal/src/layouts/Layout.tsx # packages/gatsby-theme-project-portal/src/layouts/ProjectDetailPage.stories.tsx # packages/gatsby-theme-project-portal/src/layouts/ProjectDetailPage.tsx
…eplace-sitemetadata
…eplace-sitemetadata
…eplace-sitemetadata
…eplace-sitemetadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
…eplace-sitemetadata
Prepare for handover to RENCI: Simplify internal structure of the site and its graphQL schema by removing the special projectPortalConfig object and just using the totally standard Gatsby siteMetadata.
The original intention was to have a really clear division between "siteMetadata" and the configuration particular to the Project Portal, and make it so that there was one and only one place where the project portal configuration would be loaded. Unfortunately, this just added complexity, and in most places where we used imports from the
ProjectPortalConfig
node on the graphQL database, we also did imports fromsiteMetadata
because they are so closely related.This PR removes that extra layer of complexity.