Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove additional projectPortalConfig node – put everything global on site: siteMetadata #638

Merged

Conversation

hollandjg
Copy link
Contributor

@hollandjg hollandjg commented Oct 10, 2023

Prepare for handover to RENCI: Simplify internal structure of the site and its graphQL schema by removing the special projectPortalConfig object and just using the totally standard Gatsby siteMetadata.

The original intention was to have a really clear division between "siteMetadata" and the configuration particular to the Project Portal, and make it so that there was one and only one place where the project portal configuration would be loaded. Unfortunately, this just added complexity, and in most places where we used imports from the ProjectPortalConfig node on the graphQL database, we also did imports from siteMetadata because they are so closely related.

This PR removes that extra layer of complexity.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for gatsby-theme-project-portal-ex-site ready!

Name Link
🔨 Latest commit 77db4b8
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-ex-site/deploys/654135f248b60b0008a29a41
😎 Deploy Preview https://deploy-preview-638--gatsby-theme-project-portal-ex-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for gatsby-theme-project-portal-defaults ready!

Name Link
🔨 Latest commit 77db4b8
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-defaults/deploys/654135f2199d1a000862b40f
😎 Deploy Preview https://deploy-preview-638--gatsby-theme-project-portal-defaults.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for project-portal-storybook ready!

Name Link
🔨 Latest commit 77db4b8
🔍 Latest deploy log https://app.netlify.com/sites/project-portal-storybook/deploys/654135f2f66f87000913da79
😎 Deploy Preview https://deploy-preview-638--project-portal-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hollandjg hollandjg linked an issue Oct 10, 2023 that may be closed by this pull request
2 tasks
@hollandjg hollandjg changed the base branch from main to refactor/remove-additiona-tsx-files October 10, 2023 19:53
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Note: This comment gets updated with every commit

Git SHA: 77db4b818ceaf100080e4be1a0209a0676dd1c07

Site: example-site

Pa11y test status: PASS

 {
    "total": 20,
    "passes": 20,
    "errors": 0,
    "results": {
        "http://localhost:9000/project/completed-project-nodate/": [],
        "http://localhost:9000/project/completed-project/": [],
        "http://localhost:9000/project/completed-project2/": [],
        "http://localhost:9000/project/ongoing-project-nodate/": [],
        "http://localhost:9000/project/ongoing-project/": [],
        "http://localhost:9000/project/ongoing-project2/": [],
        "http://localhost:9000/project/open-project-2/": [],
        "http://localhost:9000/project/open-project-nodate/": [],
        "http://localhost:9000/project/open-project/": [],
        "http://localhost:9000/project/open-project3/": [],
        "http://localhost:9000/project/open-project4/": [],
        "http://localhost:9000/project/open-project5/": [],
        "http://localhost:9000/project/open-project6/": [],
        "http://localhost:9000/completed/": [],
        "http://localhost:9000/": [],
        "http://localhost:9000/ongoing/": [],
        "http://localhost:9000/open/": [],
        "http://localhost:9000/about/": [],
        "http://localhost:9000/contact/": [],
        "http://localhost:9000/contact/thank-you/": []
    }
}
 

…ve-project-portal-config-node-replace-sitemetadata

# Conflicts:
#	packages/gatsby-theme-project-portal/src/layouts/Layout.tsx
#	packages/gatsby-theme-project-portal/src/layouts/ProjectDetailPage.stories.tsx
#	packages/gatsby-theme-project-portal/src/layouts/ProjectDetailPage.tsx
@hollandjg hollandjg marked this pull request as ready for review October 11, 2023 15:07
Base automatically changed from refactor/remove-additiona-tsx-files to main October 11, 2023 16:27
Copy link
Contributor

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hollandjg hollandjg added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 5dc13c1 Oct 31, 2023
12 of 15 checks passed
@hollandjg hollandjg deleted the refactor/remove-project-portal-config-node-replace-sitemetadata branch October 31, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: replace projectPortalConfig with siteMetadata or pluginOptions
2 participants