Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add automated tests using storybook #671

Merged
merged 17 commits into from
Nov 3, 2023

Conversation

hollandjg
Copy link
Contributor

@hollandjg hollandjg commented Oct 27, 2023

Leverage existing storybook examples and test them – ensure that every example in the storybook builds without failing. (We could also include tests of each component being used if we wanted, but we don't have any yet.)
Screenshot 2023-10-11 at 12 11 23

This replaces

and doesn't depend on

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for gatsby-theme-project-portal-defaults ready!

Name Link
🔨 Latest commit 28021e2
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-defaults/deploys/65452633111d1d0008e21b0d
😎 Deploy Preview https://deploy-preview-671--gatsby-theme-project-portal-defaults.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for gatsby-theme-project-portal-ex-site ready!

Name Link
🔨 Latest commit 28021e2
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-ex-site/deploys/65452633ab87bf00087b45f0
😎 Deploy Preview https://deploy-preview-671--gatsby-theme-project-portal-ex-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for project-portal-storybook ready!

Name Link
🔨 Latest commit 28021e2
🔍 Latest deploy log https://app.netlify.com/sites/project-portal-storybook/deploys/65452633111d1d0008e21b11
😎 Deploy Preview https://deploy-preview-671--project-portal-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Note: This comment gets updated with every commit

Git SHA: 28021e258c547caa2091184e5185cf285f91fca3

Site: example-site

Pa11y test status: PASS

 {
    "total": 20,
    "passes": 20,
    "errors": 0,
    "results": {
        "http://localhost:9000/project/completed-project-nodate/": [],
        "http://localhost:9000/project/completed-project/": [],
        "http://localhost:9000/project/completed-project2/": [],
        "http://localhost:9000/project/ongoing-project-nodate/": [],
        "http://localhost:9000/project/ongoing-project/": [],
        "http://localhost:9000/project/ongoing-project2/": [],
        "http://localhost:9000/project/open-project-2/": [],
        "http://localhost:9000/project/open-project-nodate/": [],
        "http://localhost:9000/project/open-project/": [],
        "http://localhost:9000/project/open-project3/": [],
        "http://localhost:9000/project/open-project4/": [],
        "http://localhost:9000/project/open-project6/": [],
        "http://localhost:9000/project/open-project5/": [],
        "http://localhost:9000/completed/": [],
        "http://localhost:9000/": [],
        "http://localhost:9000/ongoing/": [],
        "http://localhost:9000/open/": [],
        "http://localhost:9000/about/": [],
        "http://localhost:9000/contact/": [],
        "http://localhost:9000/contact/thank-you/": []
    }
}
 

@hollandjg hollandjg self-assigned this Oct 27, 2023
@hollandjg hollandjg marked this pull request as ready for review October 27, 2023 15:31
@jashlu
Copy link
Contributor

jashlu commented Nov 3, 2023

Look's good to me, thank you for this John!

@hollandjg hollandjg added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 6d4143e Nov 3, 2023
16 checks passed
@hollandjg hollandjg deleted the test/add-storybook-tests-rebased branch November 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants