Refactor linkProfile and getProfiles API + prepare for ecosystemWallet in React Native #4755
+450
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e02d87b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
joaquim-verges
requested review from
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
size-limit report 📦
|
jnsdls
requested changes
Sep 23, 2024
joaquim-verges
force-pushed
the
joaquim/smart-linking
branch
from
e7c2d30
to
f292a8d
Compare
gregfromstl
requested changes
Sep 23, 2024
packages/thirdweb/src/react/native/hooks/wallets/useProfiles.ts
Outdated
Show resolved
Hide resolved
jnsdls
reviewed
Sep 23, 2024
gregfromstl
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
jnsdls
approved these changes
Sep 24, 2024
Merge activity
|
…t in React Native (#4755) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the wallet's profile management system, enhancing the `linkProfile` and `getProfiles` functionalities. It also updates the import paths and improves the organization of wallet-related hooks and types. ### Detailed summary - Deleted `useAdminAccount.ts` and updated references to `useAdminWallet.ts`. - Refactored `linkProfile` and `getProfiles` APIs for improved functionality. - Updated import paths for `Ecosystem` type across multiple files. - Consolidated wallet profiles logic in `useProfiles` hook. - Enhanced error handling and type definitions in wallet connectors. - Added `linkProfile` and `getProfiles` methods to `InAppNativeConnector` and `InAppWebConnector`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
force-pushed
the
joaquim/smart-linking
branch
from
cb0b69e
to
e02d87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the wallet integration for the
thirdweblibrary, specifically improving the handling of user profiles and wallet authentication methods. It updates the structure of API calls and enhances the organization of wallet-related functionalities.Detailed summary
useAdminAccount.tsand its references.linkProfileandgetProfilesfunctionality toweb/lib/auth/index.jsandnative/auth/index.js.Ecosystemimport paths to a unified structure.ClientScopedStoragefor local storage management.useProfileshook to accept client arguments.